Skip to content

Fix RedundantPropertyInitializationCheck - #25930

Merged
rullzer merged 1 commit into
masterfrom
techdept/psalm/25839/RedundantPropertyInitializationCheck
Mar 9, 2021
Merged

Fix RedundantPropertyInitializationCheck#25930
rullzer merged 1 commit into
masterfrom
techdept/psalm/25839/RedundantPropertyInitializationCheck

Conversation

@rullzer

@rullzerrullzer commented Mar 4, 2021

Copy link
Copy Markdown
Member

For #25839

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzerrullzer added enhancement 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 4, 2021
@rullzerrullzer added this to the Nextcloud 22 milestone Mar 4, 2021
nickvergessen
nickvergessen reviewed Mar 5, 2021
View reviewed changes
Comment threadlib/private/Files/Storage/DAV.php
nickvergessen
nickvergessen reviewed Mar 5, 2021
View reviewed changes
Comment threadlib/private/Route/Router.php
nickvergessen
nickvergessen reviewed Mar 5, 2021
View reviewed changes
Comment threadlib/private/User/User.php
@rullzer
rullzerforce-pushed the techdept/psalm/25839/RedundantPropertyInitializationCheck branch from 2394f3d to 618805bCompareMarch 9, 2021 08:49
@rullzer

rullzer commented Mar 9, 2021

Copy link
Copy Markdown
MemberAuthor

@nickvergessen comments addressed

@rullzer
Fix RedundantPropertyInitializationCheck
618805b
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 9, 2021
@rullzer
rullzer merged commit 45cfeef into masterMar 9, 2021
@rullzer
rullzer deleted the techdept/psalm/25839/RedundantPropertyInitializationCheck branch March 9, 2021 12:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@kesselbkesselbkesselb approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@julien-ncjulien-ncAwaiting requested review from julien-nc
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@nickvergessen@ChristophWurst@kesselb