Uh oh!
There was an error while loading. Please reload this page.
Hide expiration date field for remote shares - #25933
Merged
juliusknorr merged 1 commit intoMar 9, 2021
Merged
Conversation
PVince81
requested review from
ChristophWurst, LukasReschke, juliusknorr, nickvergessen and rullzerMarch 4, 2021 15:37
PVince81
commented
Mar 4, 2021
MemberAuthor
/backport to stable21 |
PVince81
commented
Mar 4, 2021
MemberAuthor
/backport to stable20 |
PVince81
commented
Mar 4, 2021
MemberAuthor
/backport to stable19 |
PVince81
commented
Mar 4, 2021
MemberAuthor
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
bugfix/noid/remove-unsupported-remote-share-expiration
branch
from
March 4, 2021 15:51
e24a6e3 to
30b30ebComparerullzer
approved these changes
Mar 4, 2021
LukasReschke
approved these changes
Mar 8, 2021
PVince81
commented
Mar 8, 2021
MemberAuthor
/compile amend / |
Remote shares currently do not support expiration date. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81force-pushed
the
bugfix/noid/remove-unsupported-remote-share-expiration
branch
from
March 9, 2021 09:40
30b30eb to
77401e8ComparePVince81
commented
Mar 9, 2021
MemberAuthor
rebased and solved manually |
juliusknorr
approved these changes
Mar 9, 2021
juliusknorr
deleted the
bugfix/noid/remove-unsupported-remote-share-expiration
branch
March 9, 2021 15:26
This was referenced Mar 9, 2021
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote shares currently do not support expiration date.
See #25320 for a former research I did where I discovered that the backend doesn't save it yet. Making it actually work is more involved, so for now we just hide it.
It is possible that at the time where the sharing panel got converted to Vue, this specific case has not been thought of.