Uh oh!
There was an error while loading. Please reload this page.
Provisioning API to IBootstrap - #26029
Merged
Merged
Conversation
rullzer
commented
Mar 9, 2021
MemberAuthor
/backport to stable21 |
nickvergessen
approved these changes
Mar 9, 2021
8 tasks
rullzerforce-pushed
the
enh/boostrap/provisioning_api
branch
2 times, most recently
from
March 10, 2021 08:39
0f62d58 to
e5b1d59CompareSigned-off-by: Roeland Jago Douma <roeland@famdouma.nl>
PVince81
approved these changes
Mar 10, 2021
PVince81
left a comment
Member
There was a problem hiding this comment.
👍
I'm guessing this is to remove the annoying warnings in the logs ?
Assuming that the other things marked by code scanning won't spam the logs.
rullzer
commented
Mar 10, 2021
MemberAuthor
More so Joas can continue with his code :) |
Uh oh!
There was an error while loading. Please reload this page.
ChristophWurst
commented
Mar 10, 2021
Member
please address the inline psalm reports. they seem all legit :) |
nickvergessen
commented
Mar 10, 2021
Member
Just for the record we need to backport to 21, so only "cleanup" what works there. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
enh/boostrap/provisioning_api
branch
from
March 10, 2021 12:02
ebcc772 to
a1e5090CompareChristophWurst
approved these changes
Mar 10, 2021
nickvergessen
commented
Mar 10, 2021
Member
Backport worked in #26044 Not sure what the bot was complaining about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl