Skip to content

Bump @nextcloud/vue from 3.2.0 to 3.7.2 - #26057

Merged
dependabot-preview[bot] merged 3 commits into
masterfrom
dependabot/npm_and_yarn/nextcloud/vue-3.7.2
Mar 11, 2021
Merged

Bump @nextcloud/vue from 3.2.0 to 3.7.2#26057
dependabot-preview[bot] merged 3 commits into
masterfrom
dependabot/npm_and_yarn/nextcloud/vue-3.7.2

Conversation

@dependabot-preview

@dependabot-previewdependabot-previewBot commented Mar 11, 2021

Copy link
Copy Markdown
Contributor

Bumps @nextcloud/vue from 3.2.0 to 3.7.2.

Release notes

Sourced from @nextcloud/vue's releases.

v3.7.2

v3.7.2 (2021-03-10)

Full Changelog

Fixed bugs:

v3.7.1

Added

Changed

v3.7.0

v3.7.0 (2021-03-03)

Added

Changed

v3.6.0

v3.6.0 (2021-02-25)

Added

Changed

... (truncated)

Changelog

Sourced from @nextcloud/vue's changelog.

v3.7.2 (2021-03-10)

Full Changelog

Fixed bugs:

v3.7.1 (2021-03-10)

Added

Changed

v3.7.0 (2021-03-03)

Added

Changed

v3.6.0 (2021-02-25)

Added

Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @ma12-co.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@skjnldsv

This comment has been minimized.

@dependabot-preview

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@dependabot-preview

This comment has been minimized.

@skjnldsv
skjnldsv requested a review from PVince81March 11, 2021 09:04
@skjnldsv

This comment has been minimized.

@PVince81

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@PVince81

Copy link
Copy Markdown
Member

MultiSelects will need adjusting

Wow, we're so late behind? thinking

can you adjust the affected locations as you're the most familiar with this change ?

@skjnldsv

Copy link
Copy Markdown
Member

can you adjust the affected locations as you're the most familiar with this change ?

Incoming

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

dependabot-previewBotand others added 2 commits March 11, 2021 12:14
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the dependabot/npm_and_yarn/nextcloud/vue-3.7.2 branch from 2087460 to 079b110CompareMarch 11, 2021 11:17
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the dependabot/npm_and_yarn/nextcloud/vue-3.7.2 branch from 079b110 to 31ddfb0CompareMarch 11, 2021 11:30
@PVince81

PVince81 commented Mar 11, 2021

Copy link
Copy Markdown
Member

I did some quick testing with sharing and it looked fine.

However I found this issue with comments that doesn't exist on master: just try typing and observe the logs, and it's not possible to post:
image

  • BUG: REGRESSION: comments not working any more

@PVince81

PVince81 commented Mar 11, 2021

Copy link
Copy Markdown
Member
  • avatar menu works but icon misalignment (minor, could be fixed separately)

on this PR:
image

on master:
image

@dependabot-preview
dependabot-previewBot merged commit 69c4578 into masterMar 11, 2021
@dependabot-preview
dependabot-previewBot deleted the dependabot/npm_and_yarn/nextcloud/vue-3.7.2 branch March 11, 2021 14:11
@PVince81

Copy link
Copy Markdown
Member

okay, so the bot merged it automatically... let's raise tickets for the remaining issues then

@PVince81

Copy link
Copy Markdown
Member

I'll quickly look into the comment one and push a PR instead of a ticket

can someone look into avatar alignment ?

@PVince81

Copy link
Copy Markdown
Member

comments fix here: #26068

@rullzer

Copy link
Copy Markdown
Member

can someone look into avatar alignment ?

@PVince81 can you createa an issue?

@PVince81

Copy link
Copy Markdown
Member

can someone look into avatar alignment ?

@PVince81 can you createa an issue?

avatar alignment issue raised here: nextcloud-libraries/nextcloud-vue#1762

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@PVince81@rullzer@marcoambrosini