Uh oh!
There was an error while loading. Please reload this page.
Use correct exception type hint in catch statement - #26153
Merged
Conversation
Found by psalm update 4.6.2 to 4.6.3 in #26111 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
ChristophWurst, LukasReschke, icewind1991, julien-nc, kesselb and rullzerMarch 16, 2021 21:07
MorrisJobke
commented
Mar 16, 2021
MemberAuthor
/backport to stable21 |
MorrisJobke
commented
Mar 16, 2021
MemberAuthor
/backport to stable20 |
MorrisJobke
commented
Mar 16, 2021
MemberAuthor
/backport to stable19 |
ChristophWurst
approved these changes
Mar 17, 2021
This was referenced Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by psalm update 4.6.2 to 4.6.3 in #26111
The behaviour should be the same as the exception is then translated to the same exception one layer above, but now includes proper logging.