Skip to content

improve type handling of Avatar::generateAvatarFromSvg - #26282

Merged
MorrisJobke merged 1 commit into
masterfrom
psalm/avatar/data
Mar 24, 2021
Merged

improve type handling of Avatar::generateAvatarFromSvg#26282
MorrisJobke merged 1 commit into
masterfrom
psalm/avatar/data

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Noticed plsam complaining

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Mar 24, 2021
@icewind1991icewind1991 added this to the Nextcloud 22 milestone Mar 24, 2021

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2021
@MorrisJobke
MorrisJobke merged commit 2a74988 into masterMar 24, 2021
@MorrisJobke
MorrisJobke deleted the psalm/avatar/data branch March 24, 2021 20:46
@kesselb

Copy link
Copy Markdown
Contributor

/backport to stable21

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@kesselb@MorrisJobke@PVince81