Skip to content

Cleaner removePassword regex - #26346

Merged
blizzz merged 1 commit into
nextcloud:masterfrom
J0WI:clean-auth-regex
Jun 23, 2021
Merged

Cleaner removePassword regex#26346
blizzz merged 1 commit into
nextcloud:masterfrom
J0WI:clean-auth-regex

Conversation

@J0WI

@J0WIJ0WI commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@J0WIJ0WI added the 3. to review Waiting for reviews label Mar 27, 2021
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@ChristophWurst

Copy link
Copy Markdown
Member

what problem does this solve?

@J0WI

J0WI commented Apr 16, 2021

Copy link
Copy Markdown
ContributorAuthor

This enhances the readability of the regex. When using another delimiter than / you don't need to escape every / with \/. I also added some more test cases with special chars.

@J0WIJ0WI added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 26, 2021
@kesselbkesselb added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Apr 27, 2021
@J0WI
J0WI requested a review from kesselbApril 28, 2021 11:45
@J0WIJ0WI added this to the Nextcloud 22 milestone Jun 23, 2021
@blizzzblizzz mentioned this pull request Jun 23, 2021
39 tasks
@blizzz
blizzz merged commit ee7a484 into nextcloud:masterJun 23, 2021
@J0WI
J0WI deleted the clean-auth-regex branch June 23, 2021 15:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@J0WI@ChristophWurst@blizzz@kesselb