"Symfony\Component\Translation\PluralizationRules" is deprecated

[nickvergessen]

• Symfony\Component\Translation\PluralizationRules is deprecated, replacement is Symfony\Component\Translation\IdentityTranslator
• Symfony\Component\Translation\IdentityTranslator does not allow overwriting the plural function anymore, but hopefully the functions from our l10n/*.js files always had the same result anyway. At least our unit tests for L10NString still pass, so looks promising.
• Plural strings are now separated by | and count argument is %count% instead of %n
  https://github.com/nextcloud/3rdparty/blob/03eb378a5c8f29da9d0240b142bc0e7e66c31694/symfony/translation-contracts/TranslatorInterface.php#L20-L62
• Translation checker has been extended to throw on | inside translations.

[rullzer]

Looks good

[rullzer]

CI does not agree

[nickvergessen]

Fun, showed a broken string missing plurals in the test, but only with this I noticed that our placeholders dont work anymore

[nickvergessen]

Fixed by readding vsprintf at the end and adding a test in the L10nTest for it

[MorrisJobke]

CI is still very unhappy 😢

[nickvergessen]

1. Test\Share20\ManagerTest::testIsSharingDisabledForUser with data set #0 ('no', null, null, null, false)
   Method getUserGroupIds may not return value of type NULL, its return declaration is ": array"

[nickvergessen]

@MorrisJobke good to go?

[MorrisJobke]

Looks fine 👍

[MorrisJobke]

@nickvergessen Should this be backported? Was requested in 012f791#commitcomment-49915825

[nickvergessen]

So it's deprecated, should only log in debug? or does it log normally?

[ghost]

@nickvergessen It logs on several occasions as error

**Error**: Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as the first argument is deprecated since Symfony 4.3, pass it as the second argument and provide the event object as the first argument instead. at /var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php#58
1. *<<closure>>*
OC\Log\ErrorHandler::onError()
2. */var/www/nextcloud/3rdparty/symfony/event-dispatcher/EventDispatcher.php* *- line 58:*
trigger_error()
3. */var/www/nextcloud/apps/issuetemplate/lib/Controller/APIController.php* *- line 68:*
Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
4. */var/www/nextcloud/apps/issuetemplate/lib/Controller/APIController.php* *- line 84:*
OCA\IssueTemplate\Controller\APIController->queryAppDetails()
5. */var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php* *- line 218:*
OCA\IssueTemplate\Controller\APIController->details()
6. */var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php* *- line 127:*
OC\AppFramework\Http\Dispatcher->executeController()
7. */var/www/nextcloud/lib/private/AppFramework/App.php* *- line 157:*
OC\AppFramework\Http\Dispatcher->dispatch()
8. */var/www/nextcloud/lib/private/Route/Router.php* *- line 302:*
OC\AppFramework\App::main()
9. */var/www/nextcloud/lib/base.php* *- line 993:*
OC\Route\Router->match()
10. */var/www/nextcloud/index.php* *- line 37:*
OC::handleRequest()

or this one

**Error**: The "Symfony\Component\Translation\PluralizationRules" class is deprecated since Symfony 4.2. at /var/www/nextcloud/3rdparty/symfony/translation/PluralizationRules.php#38
1. *<<closure>>*
OC\Log\ErrorHandler::onError()
2. */var/www/nextcloud/3rdparty/symfony/translation/PluralizationRules.php* *- line 38:*
trigger_error()
3. */var/www/nextcloud/lib/private/L10N/L10N.php* *- line 226:*
Symfony\Component\Translation\PluralizationRules::get()
4. */var/www/nextcloud/lib/private/L10N/L10NString.php* *- line 70:*
OC\L10N\L10N->OC\L10N\{closure}(**"\**\* sensiti ... \*"**)
5. */var/www/nextcloud/lib/private/L10N/L10N.php* *- line 131:*
OC\L10N\L10NString->__toString()
6. */var/www/nextcloud/lib/private/L10N/LazyL10N.php* *- line 57:*
OC\L10N\L10N->n()
7. */var/www/nextcloud/lib/private/DateTimeFormatter.php* *- line 257:*
OC\L10N\LazyL10N->n()
8. */var/www/nextcloud/apps/settings/lib/Controller/CheckSetupController.php* *- line 534:*
OC\DateTimeFormatter->formatTimeSpan()
9. */var/www/nextcloud/apps/settings/lib/Controller/CheckSetupController.php* *- line 732:*
OCA\Settings\Controller\CheckSetupController->getLastCronInfo()
10. */var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php* *- line 218:*
OCA\Settings\Controller\CheckSetupController->check()
11. */var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php* *- line 127:*
OC\AppFramework\Http\Dispatcher->executeController()
12. */var/www/nextcloud/lib/private/AppFramework/App.php* *- line 157:*
OC\AppFramework\Http\Dispatcher->dispatch()
13. */var/www/nextcloud/lib/private/Route/Router.php* *- line 302:*
OC\AppFramework\App::main()
14. */var/www/nextcloud/lib/base.php* *- line 993:*
OC\Route\Router->match()
15. */var/www/nextcloud/index.php* *- line 37:*
OC::handleRequest()

[nickvergessen]

But if you get this in your log on a production instance it seems you have debug enabled, which you should disable, can you confirm?

[nickvergessen]

Nevermind, I found the problem... feel free to test the branch at #26762

[ghost]

Nevermind, I found the problem... feel free to test the branch at #26762

I was allready doubting myself. 🥴😄 Glad you found it.🥳

[ghost]

Works. 🛸