Skip to content

Mention MariaDB in MySQL support warning - #26474

Merged
MorrisJobke merged 1 commit into
masterfrom
caugner-patch-mariadb-in-mysql-support-warning
Apr 21, 2021
Merged

Mention MariaDB in MySQL support warning#26474
MorrisJobke merged 1 commit into
masterfrom
caugner-patch-mariadb-in-mysql-support-warning

Conversation

@caugner

Copy link
Copy Markdown
Contributor

Nextcloud warns if MySQL 5.7 is installed, as this version is no longer (officially) supported by Nextcloud 21.

Some hosters (like ALL-INKL) don't offer MySQL 8.0 yet, but offer MariaDB 10.2+ as an alternative instead. However, users of these hosters can only find out about Nextcloud's compatibility with MariaDB via the System requirements in the Administration manual.

This change informs users about the alternative by mentioning MariaDB directly in the warning.

PS: It might also make sense to link to the System requirements from all three warnings (MariaDB, MySQL, PostgreSQL).

@solracsfsolracsf added the 3. to review Waiting for reviews label Apr 10, 2021
@szaimen

Copy link
Copy Markdown
Contributor

Isn't this already covered here?

$this->description = $this->l10n->t('MariaDB version "%s" is used. Nextcloud 21 will no longer support this version and requires MariaDB 10.2 or higher.', $row['Value']);

@caugner

Copy link
Copy Markdown
ContributorAuthor

@szaimen This PR aims at informing MySQL 5.7 users that they have the choice between MySQL 8.0 and MariaDB 10.2+. The MariaDB warning you reference is only for users that use an outdated MariaDB version and isn't shown for MySQL 5.7 users.

@solracsf

Copy link
Copy Markdown
Member

@caugner you should then also advertise MariaDB users that use MySQL 8 is also an option ;)

@caugner

Copy link
Copy Markdown
ContributorAuthor

@acsfer The MariaDB warning is only shown for versions 10.1 and earlier, which are beyond their EOL, whereas MySQL 5.7 is still maintained and receives updates until 2023. So yes, we could surely add MySQL to the MariaDB warning, but I don't really think it's necessary. I would argue that most MariaDB users already know about MySQL as an alternative.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke
MorrisJobke merged commit 3e7f7e5 into masterApr 21, 2021
@MorrisJobke
MorrisJobke deleted the caugner-patch-mariadb-in-mysql-support-warning branch April 21, 2021 14:26
@MorrisJobkeMorrisJobke added this to the Nextcloud 22 milestone Apr 21, 2021
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable21

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable20

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable19

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@caugner@szaimen@solracsf@MorrisJobke