Files & Core accessibility fixes

[jancborchardt]

Before	After

Also tested with keyboard only and a screenreader.

The only thing remaining seems to be the aria-controls attribute of the search button. But I can’t figure out why, cause it does correspond to an element. Any idea @skjnldsv@GabeGabeT@szet0018 @RubyDo?

---

Here some demo of before/after of the focus feedback for file list actions, since the other ones are mostly screenreader label fixes:

Focus.effect.before.mp4

Focus.effect.afterwards.mp4

[jancborchardt]

/backport to stable21

[MarcoZehe]

The file core/js/dist/unified-search.js is impossible to review, because its diff has over 42,554 changed lines. Is there something wrong with line endings maybe so that each line apears as a changed one? Please update the patch with a more readable diff.

[skjnldsv]

The file core/js/dist/unified-search.js is impossible to review, because its diff has over 42,554 changed lines. Is there something wrong with line endings maybe so that each line apears as a changed one? Please update the patch with a more readable diff.

@MarcoZehe this one is the compiled bundle.
You need to review the source files: core/src/views/UnifiedSearch.vue

[MarcoZehe]

@skjnldsv Ah, so these patches include two compiled sources, one of them minified? Geez... Yeah that vue source file didn't have anything suspicious, but the questions and requests from my other comments are still valid.

[jancborchardt]

Fixed the issues with the "Profile picture" section. But for @MarcoZehe’s other remark, a Javascript expert would have to take over.
@skjnldsv do you want to fix the remark in here, or would you prefer we merge this and do it in a follow-up? The div should ideally become a button, and if possible we can use the ActionMenu there since our components are accessible?

And thanks a ton @MarcoZehe for the review!

[skjnldsv]

🐘

[jancborchardt]

@MarcoZehe I fixed your feedback about the label, the issue with the "divs which should be buttons" I would open as a separate issue and handle it separately, as for that I need a Javascripter to take over and it ideally shouldn’t block the merging of these fixes. Would that be ok?

[MarcoZehe]

Yes, that would be fine.

[jancborchardt]

Ah and for the record: The element is a div, but I tested with keyboard and screen reader and it does read "Change privacy level of profile picture" and the menu can be opened using space (and closed with Escape).

So mainly it is about just changing it to a button – I’m already working on preparing the follow-up pull request.

[jancborchardt]

The failures seem unrelated. Can you confirm @rullzer@skjnldsv?

[jancborchardt]

Actually almost fixed it already, but needed to use <a> instead of <button> – commit coming soon.

[jancborchardt]

Ok, resolved the basics of the menu, but this will be properly fixed once we move the rest of settings to the Vue components as well which are accessible by default. :)

[jancborchardt]

Now rebased several times, checks still failing. Seem unrelated, could you confirm @rullzer @ma12-co?

[jancborchardt]

Failures unrelated: #26314