Uh oh!
There was an error while loading. Please reload this page.
ensure redis returns bool for hasKey - #26551
Merged
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
rullzer
reviewed
Apr 14, 2021
| @@ -69,7 +69,7 @@ public function set($key, $value, $ttl = 0) { | |||
| } | |||
| public function hasKey($key) { | |||
Member
There was a problem hiding this comment.
should we type the signature as well?
MemberAuthor
There was a problem hiding this comment.
should be done in the interface, didn't want to change that. For 22 should be ok. And just backport that line.
MemberAuthor
There was a problem hiding this comment.
but then let's refurbish the whole ICache in a follow up PR since it is mostly from 2013.
rullzer
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
Return value of OC\\Http\\Client\\NegativeDnsCache::isNegativeCached() must be of the type bool, int returned",with Redis. To quote the module's doc: