Uh oh!
There was an error while loading. Please reload this page.
Do not allow adding file drop shares to your own cloud - #26613
Merged
Conversation
rullzer
requested review from
ChristophWurst, LukasReschke, MorrisJobke and nickvergessenApril 19, 2021 07:10
nickvergessen
approved these changes
Apr 19, 2021
LukasReschke
approved these changes
Apr 19, 2021
LukasReschke
left a comment
Member
There was a problem hiding this comment.
Is it also possible to add another check within $this->federatedShareProvider->create($share);? I am afraid that there are otherwise similar issues in the future :)
rullzerforce-pushed
the
enh/no_add_to_your_nc_file_drop
branch
from
April 19, 2021 10:17
3b45001 to
241dfabCompareThere is no reason for this and you can't create such shares normally anyway. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
commented
Apr 19, 2021
MemberAuthor
You mean as extra? lets first get this in for the easy backport. |
rullzer
commented
Apr 19, 2021
MemberAuthor
/backport to stable21 |
rullzer
commented
Apr 19, 2021
MemberAuthor
/backport to stable20 |
rullzer
commented
Apr 19, 2021
MemberAuthor
/backport to stable19 |
This was referenced Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason for this and you can't create such shares normally
anyway.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl