Skip to content

Make lookup search explicit - #26633

Merged
juliusknorr merged 1 commit into
masterfrom
enh/sharee/lookup_later
Apr 20, 2021
Merged

Make lookup search explicit#26633
juliusknorr merged 1 commit into
masterfrom
enh/sharee/lookup_later

Conversation

@rullzer

@rullzerrullzer commented Apr 19, 2021

Copy link
Copy Markdown
Member

Speedsup sharee lookup quite a bit.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Make lookup search explicit
dcd4542
Speedsup sharee lookup quite a bit.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added enhancement 3. to review Waiting for reviews labels Apr 19, 2021
@rullzerrullzer added this to the Nextcloud 22 milestone Apr 19, 2021
MorrisJobke
MorrisJobke approved these changes Apr 19, 2021
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice performance improvement 🚀

@MorrisJobke

MorrisJobke commented Apr 19, 2021

Copy link
Copy Markdown
Member

Bildschirmfoto 2021-04-19 um 21 46 53

@MorrisJobke

MorrisJobke commented Apr 19, 2021

Copy link
Copy Markdown
Member

Retriggered CI to check if this is related.

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2021
@rullzer

rullzer commented Apr 19, 2021

Copy link
Copy Markdown
MemberAuthor

I thinkthis one is failing since some time now?

@nickvergessen

nickvergessen commented Apr 19, 2021

Copy link
Copy Markdown
Member

Yes there is an issue by vincent about it

@juliusknorr

juliusknorr commented Apr 20, 2021

Copy link
Copy Markdown
Member

#26314 for reference

@juliusknorr
juliusknorr merged commit 59f8685 into masterApr 20, 2021
@juliusknorr
juliusknorr deleted the enh/sharee/lookup_later branch April 20, 2021 06:38
@rullzer

rullzer commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@rullzer

rullzer commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@rullzer

rullzer commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@MorrisJobke

MorrisJobke commented Apr 20, 2021

Copy link
Copy Markdown
Member

/backport to stable21

@MorrisJobke

MorrisJobke commented Apr 20, 2021

Copy link
Copy Markdown
Member

/backport to stable20

@MorrisJobke

MorrisJobke commented Apr 20, 2021

Copy link
Copy Markdown
Member

/backport to stable19

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 20, 2021

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 20, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 20, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 20, 2021

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 20, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 20, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@MorrisJobke

MorrisJobke commented Apr 20, 2021

Copy link
Copy Markdown
Member

@rullzer MInd to do the backports?

@rullzer

rullzer commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 20, 2021
Merged
@rullzer

rullzer commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@rullzer

rullzer commented Apr 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 20, 2021
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 20, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@LukasReschkeLukasReschkeLukasReschke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer@MorrisJobke@nickvergessen@juliusknorr@LukasReschke