Fix occ db:convert-type, issue #26085

[hankjordan]

When using occ db:convert-type, the command fails with the following message:

Only strings, Literals and Parameters are allowed

This pull request fixes the error and resolves issue #26085 using the original poster's proposed solution.

---

Signed-off-by: Henry Jordan hank@henryjordan.com

[hankjordan]

Note to maintainers: DCO check is wrong. Commit messages are correct.

[julien-nc]

Looks fine but I didn't try it.

[kesselb]

server/core/Command/Db/ConvertType.php

Lines 337 to 348 in 68c8fa8

	try {
	$orderColumns = $table->getPrimaryKeyColumns();
	} catch (Exception$e) {
	$orderColumns = [];
	foreach ($table->getColumns() as$column) {
	$orderColumns[] = $column->getName();
	}
	}
	foreach ($orderColumnsas$column) {
	$query->addOrderBy($column);
	}

I think we should fix it there. addOrderBy should not accept a column object.

[kesselb]

To pass the DCO check. For more details: https://github.com/nextcloud/server/pull/26855/checks?check_run_id=2492874912

[kesselb]

server/core/Command/Db/ConvertType.php

Lines 337 to 348 in 68c8fa8

	try {
	$orderColumns = $table->getPrimaryKeyColumns();
	} catch (Exception$e) {
	$orderColumns = [];
	foreach ($table->getColumns() as$column) {
	$orderColumns[] = $column->getName();
	}
	}
	foreach ($orderColumnsas$column) {
	$query->addOrderBy($column);
	}

I'm not a fan of adding more logic to quote helper when the actual issue is another method using it wrong.

try {
$orderColumns = $table->getPrimaryKeyColumns();
} catch (Exception $e) {
$orderColumns = $table->getColumns();
}
foreach ($orderColumns as $column) {
$query->addOrderBy($column->getName());
}

Should also fix it. If we accept this patch we need to update IQueryBuilder and document that addOrderBy and orderBy also accept a Column object.

[FarisZR]

can confirm this fixed the issue