Let apps toggle an unread counter on app icons

[juliusknorr]

The count value is currently hidden as we don't want to clutter the UI too much, but might be useful at some point.

It can either be updated during page load through the navigation manager $navigationManager->setUnreadCounter('activity', 10); or through JavaScript by calling OC.setNavigationCounter('deck', 123)

[juliusknorr]

I'm a bit undecided on the approach to take here, maybe we should rather listen to an event that might be emitted then by the apps through the event bus?

[ChristophWurst]

I'd advocate against the global variable approach, at least form an app API perspective. We can hide this in yet another @nextcloud/xyz package or add it to an existing one. Then we can also later on change the way this action propagates from an app to the server component.

[juliusknorr]

OK, then lets keep the OC.setNavigationCounter for use in the additional package then which we then can use for offering a stable API. Unfortunately I don't think we have any fitting package for that already so it would need an additional one.

[jancborchardt]

For reference what I also said in the chat:
While the dot below looks very nice, it is most known as "active" indicator instead of for "notifications":

• in Nextcloud Text
• GNOME app switcher
• macOS Dock
• on websites like https://humanebydesign.com/

In the notifications app we provide 2 icons, 1 regular and 1 with dot. We could do the same with the app icons as well, and standardize the position and size via recommendation. That way we can also achieve the cut-out border for the dot which is difficult to do via CSS because we have a fade in the header.

[blizzz]

what's the state here? moving to 23?

[juliusknorr]

Ready review, we'd still need this for 22.

[blizzz]

CI is unhappy

[jancborchardt]

👍 design-wise :)

[juliusknorr]

Pushed another fix for the tests, waiting for CI to pass

[blizzz]

CI is unhappy