Use parent wrapper to properly handle moves on the same source/target storage

[juliusknorr]

Steps to reproduce:

• Share a folder from a groupfolder to another user
• Try to upload a file to the shared folder as the user without access to the original groupfolder

Moving the part file to the final one failed after #25568 as the general wrapper logic to use a rename instead of a moveFromStorage from

server/lib/private/Files/Storage/Wrapper/Wrapper.php

Lines 573 to 577 in 3e69ed8

	if ($sourceStorage === $this) {
	return$this->rename($sourceInternalPath, $targetInternalPath);
	}
	return$this->getWrapperStorage()->moveFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);

was not called anymore.

Fixesnextcloud/groupfolders#1453
Fixesnextcloud/groupfolders#1445

[juliusknorr]

/backport to stable21

[juliusknorr]

/backport to stable20

[MorrisJobke]

Tested and works 👍

[mowtee]

Tested it and fixed our issue. Thank you so much!

[rullzer]

Makes sense.

[jknockaert]

Would it be possible to add a test to avoid this type of issues?

[ornanovitch]

will this be included in 21.0.2 or shall we patch manually until a later version?

[MorrisJobke]

will this be included in 21.0.2 or shall we patch manually until a later version?

21.0.2 will definitely not have it, because it will be released on Thursday and the merge window for that version is already closed. Maybe we backport this to 21.0.3.

@juliushaertl Opinions on the backport?

[MorrisJobke]

Ah .. it already is scheduled for a backport

[MorrisJobke]

/backport to stable21

[MorrisJobke]

/backport to stable20

[backportbot-nextcloud]

The backport to stable21 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable20 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable21 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable20 failed. Please do this backport manually.

[juliusknorr]

stable21 #27015
stable20 #27016

[nextclouduser74]

Am not a developer just admin and I tried this fix, and it seems to work, BUT:
You put something in the shared subfolder of groupfolders <-- this didn't work before the fix it works now,
when you try to move it to your Home-Folder you get again this here:

Error	core	unable to rename, source directory is not writable :

The failure is the same. Path is /mnt/data/shared_subfolder instead of /mnt/data/__groupfolders/number/shared_subfolder.

Copying/Moving INTO the share works now, moving something out of the share doesn't work. The only way is to copy the file/folder to the destination and then delete it.