Skip to content

Harden apptoken check - #27000

Merged
rullzer merged 1 commit into
masterfrom
enh/apptoken/check_apptoken
May 18, 2021
Merged

Harden apptoken check#27000
rullzer merged 1 commit into
masterfrom
enh/apptoken/check_apptoken

Conversation

@rullzer

@rullzerrullzer commented May 17, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzerrullzer added the 2. developing Work in progress label May 17, 2021
@rullzerrullzer added this to the Nextcloud 22 milestone May 17, 2021
@rullzer
rullzerforce-pushed the enh/apptoken/check_apptoken branch from 0bcb1ae to 4a2775aCompareMay 17, 2021 14:04
@rullzer
Harden apptoken check
4a2775a
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 18, 2021
nickvergessen
nickvergessen approved these changes May 18, 2021
View reviewed changes

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now

@rullzer
rullzer merged commit e008b79 into masterMay 18, 2021
@rullzer
rullzer deleted the enh/apptoken/check_apptoken branch May 18, 2021 07:28
@rullzer

rullzer commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@rullzer

rullzer commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@rullzer

rullzer commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@backportbot-nextcloud

backportbot-nextcloudBot commented May 18, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented May 18, 2021

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented May 18, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@rullzer

rullzer commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 18, 2021
Merged
@rullzer

rullzer commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@rullzer

rullzer commented May 18, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 18, 2021
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 18, 2021
Merged
@dublutz

dublutz commented Jul 6, 2021

Copy link
Copy Markdown

Hi guys, thank you for your work on this one.
I guess I'm missing the context but why do you return Http::STATUS_BAD_REQUEST status code when the $this->checkAppToken() returns TRUE. This means that the session exists, right? Thanks for clarifying!

@nickvergessen

nickvergessen commented Jul 7, 2021

Copy link
Copy Markdown
Member

When the request is done by an apptoken it is not allowed to manage app tokens. Otherwise an app token could create another app token. This is not wanted.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@LukasReschkeLukasReschkeLukasReschke approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@dublutz@nickvergessen@LukasReschke