print the backup codes tab and not the current one by ChristophWurst · Pull Request #2704 · nextcloud/server

ChristophWurst · 2016-12-15T17:20:56Z

Before, the current tab was printed (and closed), not the temporary one with the backup codes.

Should be backported IMO. cc @karlitschek

mention-bot · 2016-12-15T17:20:57Z

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer.

karlitschek · 2016-12-15T17:22:55Z

please backport 👍

nickvergessen · 2016-12-15T17:24:08Z

Doesn't work here with FF:
mozilla.pdf

ChristophWurst · 2016-12-15T17:25:40Z

Doesn't work here with FF:
mozilla.pdf

Works here with 50.1.0 🤔

ChristophWurst · 2016-12-15T17:26:56Z

Ouch. Doesn't work on Chromium either.

ChristophWurst · 2016-12-19T12:52:35Z

For some reason Chrome doesn't allow the "old" approach anymore, it closes the tab immediately if a data url is used. Now I'm using the window object to write to its document. Apparently that works on all browsers I have tested:

FF 50
Chromium (default settings, e.g. pop-ups are blocked)
Gnome Web

I don't have IE nor Safari, we should test those too as I'm not too confident that it works everywhere. Maybe @MorrisJobke or @LukasReschke can help here 😁

ChristophWurst · 2016-12-20T13:53:58Z

+ var data = this._getDownloadData();
+ var newTab = window.open('', t('twofactor_backupcodes', 'Nextcloud backup codes'));
+ newTab.document.write('<h1>' + t('twofactor_backupcodes', 'Nextcloud backup codes') + '</h1>');
+ newTab.document.write(data);


cc @LukasReschke for possible security implications of writing to the document directly

… codes Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst · 2017-01-17T09:32:52Z

rebased

codecov-io · 2017-01-17T10:00:42Z

Current coverage is 53.92% (diff: 100%)

Merging #2704 into master will not change coverage

@@ master #2704 diff @@
==========================================
Files 1302 1302 Lines 80097 80097 Methods 7905 7905 Messages 0 0 Branches 1245 1245 ==========================================
Hits 43189 43189 Misses 36908 36908 Partials 0 0

Powered by Codecov. Last update b1a8296...3295fe2

MorrisJobke

Tested and works with Firefox, Safari and Chrome 👍

MorrisJobke · 2017-02-10T19:38:34Z

@nickvergessen @rullzer @schiessle @LukasReschke Mind to review this one?

MorrisJobke · 2017-02-15T15:56:59Z

@nickvergessen @rullzer @schiessle @LukasReschke Mind to review this one?

Ping

MorrisJobke · 2017-02-15T19:21:25Z

@ChristophWurst Please open a backport PR ;)

ChristophWurst · 2017-02-16T15:21:49Z

@ChristophWurst Please open a backport PR ;)

Done: #3510 :-)

ChristophWurst added 3. to review Waiting for reviews backport-request bug labels Dec 15, 2016

ChristophWurst added this to the Nextcloud 12.0 milestone Dec 15, 2016

ChristophWurst requested review from LukasReschke, juliusknorr and nickvergessen December 15, 2016 17:20

ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 15, 2016

ChristophWurst force-pushed the 2fa-fix-backup-codes-print branch from 6bc4b09 to f86c71bCompare December 19, 2016 12:48

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 20, 2016

ChristophWurst requested a review from MariusBluem December 20, 2016 13:53

ChristophWurst commented Dec 20, 2016
View reviewed changes

ChristophWurst added 2 commits January 17, 2017 10:32

print and close the new tab, not the current one when printing backup…
e111015
… codes Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

add title to backup codes print page
3295fe2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst force-pushed the 2fa-fix-backup-codes-print branch from 8fb43ce to 3295fe2Compare January 17, 2017 09:32

MorrisJobke approved these changes Jan 26, 2017
View reviewed changes

ChristophWurst requested review from irgendwie and rullzer February 6, 2017 09:02

rullzer approved these changes Feb 15, 2017
View reviewed changes

rullzer merged commit 2d8b7b8 into masterFeb 15, 2017

rullzer deleted the 2fa-fix-backup-codes-print branch February 15, 2017 19:18

ChristophWurst mentioned this pull request Feb 16, 2017
[stable11] fix printing backup codes #3510
Merged

MorrisJobke removed the backport-request label Feb 16, 2017

MorrisJobke mentioned this pull request Feb 17, 2017
Save backup codes is broken #3520
Closed

ChristophWurst mentioned this pull request Feb 28, 2017
Fix saving backup codes by using a correct data uri #3649
Merged

Uh oh!

Uh oh!

Conversation

ChristophWurst commented Dec 15, 2016

Uh oh!

mention-bot commented Dec 15, 2016

Uh oh!

karlitschek commented Dec 15, 2016

Uh oh!

nickvergessen commented Dec 15, 2016

Uh oh!

ChristophWurst commented Dec 15, 2016

Uh oh!

ChristophWurst commented Dec 15, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChristophWurst commented Dec 19, 2016

Uh oh!

ChristophWurstDec 20, 2016

Choose a reason for hiding this comment

Uh oh!

ChristophWurst commented Jan 17, 2017

Uh oh!

codecov-io commented Jan 17, 2017

Current coverage is 53.92% (diff: 100%)

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Feb 10, 2017

Uh oh!

MorrisJobke commented Feb 15, 2017

Uh oh!

MorrisJobke commented Feb 15, 2017

Uh oh!

ChristophWurst commented Feb 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ChristophWurst commented Dec 15, 2016•
edited
Loading