Skip to content

Fix Oracle query limit compliance in Comments - #27187

Merged
MorrisJobke merged 1 commit into
nextcloud:masterfrom
Simounet:fix/comments-query-oracle-limit-compliance
May 28, 2021
Merged

Fix Oracle query limit compliance in Comments#27187
MorrisJobke merged 1 commit into
nextcloud:masterfrom
Simounet:fix/comments-query-oracle-limit-compliance

Conversation

@Simounet

Copy link
Copy Markdown
Member

Hi there,
Resolving one more issue about Oracle query limit (#25036) on Nextcloud comments queries.
Could resolve#26493 and related to #4947.
Have a nice day and stay safe.

@AndyXheli

AndyXheli commented May 27, 2021

Copy link
Copy Markdown
Contributor

@ChristophWurst@rullzer@MorrisJobke When you get a chance can you please review :)

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Comment threadlib/private/Comments/Manager.php Outdated
@blizzzblizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 27, 2021
Comment threadlib/private/Comments/Manager.php Outdated
Signed-off-by: Simounet <contact@simounet.net>
@Simounet
Simounetforce-pushed the fix/comments-query-oracle-limit-compliance branch from 6bec93f to a50eba1CompareMay 28, 2021 06:48

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code looks good

@MorrisJobke

Copy link
Copy Markdown
Member

Failure is unrelated and a regression on master -> merge

@MorrisJobke
MorrisJobke merged commit fb78991 into nextcloud:masterMay 28, 2021
@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable21

@Simounet
Simounet deleted the fix/comments-query-oracle-limit-compliance branch May 28, 2021 10:06
@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable21

@MorrisJobke

Copy link
Copy Markdown
Member

/backport to stable21

@AndyXheli

AndyXheli commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

@LukasReschke Once i added the changes that @nickvergessen implanted the server stopped working Fix populating the array and closing the cursors #27316

{"reqId":"IaCrQFzY4jvDY9zBZ77j","level":4,"time":"2021-06-01T19:16:58+00:00","remoteAddr":"0.0.0.0","user":"admin","app":"webdav","method":"PROPFIND","url":"/remote.php/dav/files/admin/","message":{"Exception":"Error","Message":"Call to undefined method OC\DB\QueryBuilder\QueryBuilder::executeQuery()","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/CommentPropertiesPlugin.php","line":89,"function":"getNumberOfUnreadCommentsForObjects","class":"OC\Comments\Manager","type":"->"},{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/CommentPropertiesPlugin.php","line":117,"function":"cacheDirectory","class":"OCA\DAV\Connector\Sabre\CommentPropertiesPlugin","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"handleGetProperties","class":"OCA\DAV\Connector\Sabre\CommentPropertiesPlugin","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":1052,"function":"emit","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":984,"function":"getPropertiesByNode","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":1661,"function":"getPropertiesIteratorForPath","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":1646,"function":"writeMultiStatus","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":346,"function":"generateMultiStatus","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpPropFind","class":"Sabre\DAV\CorePlugin","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":472,"function":"emit","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":253,"function":"invokeMethod","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":321,"function":"start","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/lib/Server.php","line":332,"function":"exec","class":"Sabre\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/appinfo/v2/remote.php","line":35,"function":"exec","class":"OCA\DAV\Server","type":"->"},{"file":"/var/www/nextcloud/remote.php","line":167,"args":["/var/www/nextcloud/apps/dav/appinfo/v2/remote.php"],"function":"require_once"}],"File":"/var/www/nextcloud/lib/private/Comments/Manager.php","Line":662,"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36","version":"21.0.2.1","id":"60b688d036699"}

@blizzzblizzz mentioned this pull request Jun 2, 2021
57 tasks

@AndyXheliAndyXheli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once i added the changes that @nickvergessen implanted in #27316 the server stopped working the code worked before the changes.

@AndyXheli

Copy link
Copy Markdown
Contributor

@MorrisJobke Just wanted to let you know that this is not on NC 21.0.3

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doctrine\DBAL\Query\QueryException: More than 1000 expressions in a list are not allowed on Oracle

7 participants

@Simounet@AndyXheli@MorrisJobke@juliusknorr@nickvergessen@ChristophWurst@blizzz