Skip to content

[stable20] better cleanup of filecache when deleting an external storage - #27207

Closed
backportbot-nextcloud[bot] wants to merge 2 commits into
stable20from
backport/26936/stable20
Closed

[stable20] better cleanup of filecache when deleting an external storage#27207
backportbot-nextcloud[bot] wants to merge 2 commits into
stable20from
backport/26936/stable20

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented May 28, 2021

Copy link
Copy Markdown

backport of #26936

@MorrisJobkeMorrisJobke added the 3. to review Waiting for reviews label May 28, 2021
@blizzzblizzz mentioned this pull request Jun 23, 2021
Merged
6 tasks
@blizzz

blizzz commented Jun 23, 2021

Copy link
Copy Markdown
Member

CI is unhappy

@blizzzblizzz mentioned this pull request Jul 1, 2021
Merged
4 tasks
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 1, 2021
@github-actions
github-actionsBotforce-pushed the backport/26936/stable20 branch from d0a5cf3 to 37c428fCompareJuly 15, 2021 20:12
@skjnldsvskjnldsv mentioned this pull request Jul 26, 2021
Merged
11 tasks
@skjnldsv

skjnldsv commented Jul 28, 2021

Copy link
Copy Markdown
Member

/rebase

@github-actions
github-actionsBotforce-pushed the backport/26936/stable20 branch from 37c428f to 7344770CompareJuly 28, 2021 05:37
@skjnldsvskjnldsv reopened this Jul 28, 2021
@skjnldsvskjnldsv mentioned this pull request Aug 3, 2021
Merged
9 tasks
@blizzzblizzz mentioned this pull request Sep 23, 2021
Merged
8 tasks
@MichaIng
MichaIngforce-pushed the backport/26936/stable20 branch from 7344770 to 7311ce9CompareSeptember 24, 2021 12:00
@MichaIng

MichaIng commented Sep 30, 2021

Copy link
Copy Markdown
Member

Strange, static code analysis diff is identical to here: https://github.com/nextcloud/server/pull/26630/checks?check_run_id=3699661869

@MichaIng
MichaIngforce-pushed the backport/26936/stable20 branch from 7311ce9 to 90ee38aCompareOctober 12, 2021 11:34
@skjnldsv

skjnldsv commented Oct 19, 2021

Copy link
Copy Markdown
Member

/rebase

@blizzz

blizzz commented Oct 20, 2021

Copy link
Copy Markdown
Member

CI unhappy

@MichaIng

MichaIng commented Oct 20, 2021

Copy link
Copy Markdown
Member

executeQuery was added with NC22: 76a6328

@blizzzblizzz mentioned this pull request Nov 3, 2021
Merged
15 tasks
MichaIng
MichaIng requested changes Nov 18, 2021
View reviewed changes
Comment threadlib/private/Files/Cache/Storage.php Outdated
Comment threadlib/private/Files/Cache/Storage.php Outdated
@icewind1991@MichaIng
better cleanup of filecache when deleting an external storage
b83c947
this way it can delete the cache entries even with per-user credentials
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MichaIng
MichaIngforce-pushed the backport/26936/stable20 branch from 74261d2 to b83c947CompareNovember 18, 2021 13:34
MichaIng
MichaIng approved these changes Nov 18, 2021
View reviewed changes

@MichaIngMichaIng left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining Psalm errors are unrelated and should be solved with: #29556

@MichaIngMichaIng added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Nov 18, 2021
MichaIng
MichaIng requested changes Nov 18, 2021
View reviewed changes

@MichaIngMichaIng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, more changes required...

@MichaIng
Use pre-v22 query commands
ab36256
Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng
MichaIngforce-pushed the backport/26936/stable20 branch from cc52cdf to ab36256CompareNovember 18, 2021 14:11
@MichaIng

MichaIng commented Nov 18, 2021•
edited
Loading

Copy link
Copy Markdown
Member

lib/private/Files/Cache/Storage.php#L244
Argument 2 of OCP\DB\QueryBuilder\IExpressionBuilder::in expects array<array-key, mixed>|string, OCP\DB\QueryBuilder\IParameter provided with a __toString method

This is related, not present on NC21 backport anymore, but currently not sure how to solve it. Probably this included the fix?

@rakeknivenrakekniven removed this from the Nextcloud 20.0.14 milestone Nov 19, 2021
@MichaIng

MichaIng commented Nov 19, 2021

Copy link
Copy Markdown
Member

Marking as closed as NC20 is EOL. If wanted to customers, it can be reopened at any time.

@MichaIng
MichaIng deleted the backport/26936/stable20 branch November 19, 2021 13:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaIngMichaIngMichaIng requested changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@icewind1991icewind1991Awaiting requested review from icewind1991
@julien-ncjulien-ncAwaiting requested review from julien-nc
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl

Assignees

No one assigned

Labels

2. developingWork in progressfeature: external storagefeature: filesystem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@blizzz@skjnldsv@MichaIng@MorrisJobke@rakekniven@icewind1991