Skip to content

Update psalm-baseline.xml in stable21 - #27373

Closed
nickvergessen wants to merge 1 commit into
stable21from
update-psalm-baseline
Closed

Update psalm-baseline.xml in stable21#27373
nickvergessen wants to merge 1 commit into
stable21from
update-psalm-baseline

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Should make CI green again

Signed-off-by: Joas Schilling <coding@schilljs.com>
@skjnldsv

Copy link
Copy Markdown
Member

Static code analysis / static-code-analysis (pull_request) Failing after 2m — static-code-analysis

@skjnldsv

Copy link
Copy Markdown
Member
/home/runner/work/server/server/apps/files_external/lib/Lib/Storage/SFTPReadStream.php:175:10:error - FalsableReturnStatement: The declared return type 'int' for OCA\Files_External\Lib\Storage\SFTPReadStream::stream_write does not allow false, but the function returns 'false'
/home/runner/work/server/server/apps/files_external/lib/Lib/Storage/SFTPReadStream.php:187:10:error - FalsableReturnStatement: The declared return type 'array<array-key, mixed>' for OCA\Files_External\Lib\Storage\SFTPReadStream::stream_stat does not allow false, but the function returns 'false'
/home/runner/work/server/server/apps/files_external/lib/Lib/Storage/SFTPWriteStream.php:129:10:error - FalsableReturnStatement: The declared return type 'string' for OCA\Files_External\Lib\Storage\SFTPWriteStream::stream_read does not allow false, but the function returns 'false'
/home/runner/work/server/server/apps/files_external/lib/Lib/Storage/SFTPWriteStream.php:140:12:error - FalsableReturnStatement: The declared return type 'int' for OCA\Files_External\Lib\Storage\SFTPWriteStream::stream_write does not allow false, but the function returns 'false'
/home/runner/work/server/server/apps/files_external/lib/Lib/Storage/SFTPWriteStream.php:156:10:error - FalsableReturnStatement: The declared return type 'array<array-key, mixed>' for OCA\Files_External\Lib\Storage\SFTPWriteStream::stream_stat does not allow false, but the function returns 'false'
/home/runner/work/server/server/lib/private/Files/Stream/SeekableHttpStream.php:124:11:error - FalsableReturnStatement: The declared return type 'string' for OC\Files\Stream\SeekableHttpStream::stream_read does not allow false, but the function returns 'false'
/home/runner/work/server/server/lib/private/Files/Stream/SeekableHttpStream.php:157:11:error - FalsableReturnStatement: The declared return type 'array<array-key, mixed>' for OC\Files\Stream\SeekableHttpStream::stream_stat does not allow false, but the function returns 'false'
/home/runner/work/server/server/lib/private/Files/Stream/SeekableHttpStream.php:176:10:error - FalsableReturnStatement: The declared return type 'int' for OC\Files\Stream\SeekableHttpStream::stream_write does not allow false, but the function returns 'false'

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Seems local version was too different 🤔

@MorrisJobke

Copy link
Copy Markdown
Member

Should make CI green again

Should make CI green again

The problem was fixed by #27346.

As this only removes stuff it could not fix issues, as fewer issues is not an error case for psalm. So I will close this here as it is fixed with a different PR.

@MorrisJobke
MorrisJobke deleted the update-psalm-baseline branch June 7, 2021 08:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@skjnldsv@MorrisJobke