Uh oh!
There was an error while loading. Please reload this page.
[stable20] avoid fread on directories and unencrypted files - #27407
Merged
Conversation
backportbot-nextcloudBot
requested review from
danxuliu, icewind1991, jknockaert, juliusknorr, kesselb, rullzer, schiessle and vitormattosJune 6, 2021 18:02
blizzz
commented
Jun 23, 2021
Member
CI is unhappy |
MichaIng
commented
Sep 3, 2021
Member
/rebase |
added 7 commits
September 3, 2021 13:42
Reworking the logic in order to first check the filecache and only then reading the fileheader. This in order to solve #21578.
Signed-off-by: Jasper Knockaert jasper@knockaert.nl
nextcloud-commandforce-pushed
the
backport/24966/stable20
branch
from
September 3, 2021 13:42
82cd9ed to
8466c53Comparekesselb
removed their request for review
September 3, 2021 13:49
MichaIng
commented
Sep 3, 2021
Member
All fine now, only DCO is unhappy. |
MichaIng
approved these changes
Sep 3, 2021
blizzz
approved these changes
Sep 23, 2021
blizzz
commented
Sep 23, 2021
Member
Let's assume them being signed-off in master is sufficient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #24966