Skip to content

Reset checksum when writing files to object store - #27586

Merged
blizzz merged 1 commit into
masterfrom
bugfi/noid/objectstore-checksum
Jul 1, 2021
Merged

Reset checksum when writing files to object store#27586
blizzz merged 1 commit into
masterfrom
bugfi/noid/objectstore-checksum

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jun 21, 2021•
edited
Loading

Copy link
Copy Markdown
Member

With a local storage the checksum will be reset when scanning the file after writing to it:

server/lib/private/Files/Cache/Scanner.php

Line 222 in 215aef3

$newData['checksum'] = '';

This does not work for object store storage backends as those use a NoopScanner so the checksum was never reset for those.

Fixes#27563

@juliusknorr
Reset checksum when writing files to object store
21db463
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added this to the Nextcloud 22 milestone Jun 21, 2021
blizzz
blizzz approved these changes Jun 22, 2021
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz

blizzz commented Jun 22, 2021

Copy link
Copy Markdown
Member

are backports necessary?

kesselb
kesselb reviewed Jun 22, 2021
View reviewed changes

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what icewind thinks.

@blizzzblizzz mentioned this pull request Jun 23, 2021
Merged
39 tasks
@juliusknorrjuliusknorr mentioned this pull request Jun 24, 2021
Closed
@blizzzblizzz modified the milestones: Nextcloud 22, Nextcloud 23Jun 24, 2021
@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 29, 2021
@juliusknorr

juliusknorr commented Jun 29, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@juliusknorr

juliusknorr commented Jun 29, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@juliusknorr

juliusknorr commented Jun 29, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@ImaCrea

ImaCrea commented Jul 1, 2021•
edited
Loading

Copy link
Copy Markdown

/backport to stable20

Hello, do you think it would be possible to backport it to 19? Or is it risky/not recommended? Thanks for your help :)

@blizzz

blizzz commented Jul 1, 2021

Copy link
Copy Markdown
Member

/backport to stable20

Hello, do you think it would be possible to backport it to 19? Or is it risky/not recommended? Thanks for your help :)

19 is having its last release today and goes EOL. So it would not get included.

@blizzz
blizzz merged commit 62675eb into masterJul 1, 2021
@blizzz
blizzz deleted the bugfi/noid/objectstore-checksum branch July 1, 2021 15:30
This was referenced Jul 1, 2021
Merged
Merged
Merged
@ImaCrea

ImaCrea commented Jul 1, 2021

Copy link
Copy Markdown

/backport to stable20

Hello, do you think it would be possible to backport it to 19? Or is it risky/not recommended? Thanks for your help :)

19 is having its last release today and goes EOL. So it would not get included.

Oh, didn't know that. Thanks for the info ! Gotta update quick I guess :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@icewind1991icewind1991icewind1991 approved these changes
@blizzzblizzzblizzz approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: object storage

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

Synchronization checksum error on a document modified online (onlyoffice)

5 participants

@juliusknorr@blizzz@ImaCrea@icewind1991@kesselb