mail-template - don't show hyphen if slogan is empty

[szaimen]

Fix#25174
Signed-off-by: szaimen szaimen@e.mail.de

[szaimen]

The test failures are unrelated, afaics.
@nextcloud/server please review

[LukasReschke]

@szaimen I don't think they are all unrelated. Check https://drone.nextcloud.com/nextcloud/server/6463/9/4

- <p class="text-center float-center" align="center" style="Margin:0;Margin-bottom:10px;color:#C8C8C8;font-family:-apple-system,BlinkMacSystemFont,'Segoe UI',Roboto,Oxygen-Sans,Ubuntu,Cantarell,'Helvetica Neue',Arial,sans-serif;font-size:12px;font-weight:400;line-height:16px;margin:0;margin-bottom:10px;padding:0;text-align:center">TestCloud - <br>This is an automatically sent email, please do not reply.</p>\n
157 | + <p class="text-center float-center" align="center" style="Margin:0;Margin-bottom:10px;color:#C8C8C8;font-family:-apple-system,BlinkMacSystemFont,'Segoe UI',Roboto,Oxygen-Sans,Ubuntu,Cantarell,'Helvetica Neue',Arial,sans-serif;font-size:12px;font-weight:400;line-height:16px;margin:0;margin-bottom:10px;padding:0;text-align:center">TestCloud<br>This is an automatically sent email, please do not reply.</p>\n
158
<br class="Apple-interchange-newline">

[szaimen]

@szaimen I don't think they are all unrelated. Check https://drone.nextcloud.com/nextcloud/server/6463/9/4

- <p class="text-center float-center" align="center" style="Margin:0;Margin-bottom:10px;color:#C8C8C8;font-family:-apple-system,BlinkMacSystemFont,'Segoe UI',Roboto,Oxygen-Sans,Ubuntu,Cantarell,'Helvetica Neue',Arial,sans-serif;font-size:12px;font-weight:400;line-height:16px;margin:0;margin-bottom:10px;padding:0;text-align:center">TestCloud - <br>This is an automatically sent email, please do not reply.</p>\n
157 | + <p class="text-center float-center" align="center" style="Margin:0;Margin-bottom:10px;color:#C8C8C8;font-family:-apple-system,BlinkMacSystemFont,'Segoe UI',Roboto,Oxygen-Sans,Ubuntu,Cantarell,'Helvetica Neue',Arial,sans-serif;font-size:12px;font-weight:400;line-height:16px;margin:0;margin-bottom:10px;padding:0;text-align:center">TestCloud<br>This is an automatically sent email, please do not reply.</p>\n
158
<br class="Apple-interchange-newline">

Thanks! in which file does this test need to be adjusted?

[LukasReschke]

Should be the following as per Drone output:

• /drone/src/apps/settings/tests/Mailer/NewUserMailHelperTest.php:384
• /drone/src/apps/settings/tests/Mailer/NewUserMailHelperTest.php:835
• /drone/src/apps/settings/tests/Mailer/NewUserMailHelperTest.php:616

(the drone UI is a bit unintuitive with failures as the errors are only shown at top in the text)

[szaimen]

Thanks! I'll have a look.

[szaimen]

I was able to fix the NewUserMailHelperTest test :)

[LukasReschke]

Error looks indeed unrelated now :)