Uh oh!
There was an error while loading. Please reload this page.
Use search to get versions list from cache for expiry - #27637
Merged
Conversation
icewind1991force-pushed
the
version-expire-search
branch
from
June 23, 2021 14:15
a425a01 to
e246126Comparejuliusknorr
approved these changes
Jun 29, 2021
skjnldsv
approved these changes
Aug 18, 2021
skjnldsv
commented
Aug 18, 2021
Member
Please rebase :) |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
version-expire-search
branch
from
August 18, 2021 14:47
e246126 to
c3fb5acCompareSigned-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
version-expire-search
branch
from
August 18, 2021 14:52
c3fb5ac to
5f101d9Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of traversing the filesystem, get the list from cache.
Future improvement would be changing the mtime of the version files to the version data, which would make getting all expired ones easy and cheap. But that requires a migration step so is a bit more involved.