Skip to content

LDAP: determine shares of offline users only when needed - #27698

Merged
blizzz merged 1 commit into
masterfrom
fix/25761/userexistsonldap-loop
Jun 28, 2021
Merged

LDAP: determine shares of offline users only when needed#27698
blizzz merged 1 commit into
masterfrom
fix/25761/userexistsonldap-loop

Conversation

@blizzz

@blizzzblizzz commented Jun 28, 2021•
edited
Loading

Copy link
Copy Markdown
Member

The story behind is this:

  1. On a migration call that loops over all users
  2. Also all known LDAP users get into consideration
  3. including those that are not found on LDAP anymore (OfflineUser)
  4. and userExists is run against each user
  5. which also causes an existency check against the LDAP server
  6. for which the DN is required
  7. the getter of the OfflinerUser triggered fetching all details
  8. including checking whether they are a sharee
  9. which depending on the share provider logic might invoke a user existence check

But the only place where we need the information is the ldap:show-remnants command.

fixes a segfault on a migration step of accessibility app on upgrade #25761 (wrong issue)

@blizzz
LDAP: determine shares of offline users only when needed
bbcd8c9
- determine shares may via Sharing code result in user exists checks
- this may result in an infinite loop when user exists was called before
- the info is really only required at one occ command
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 23 milestone Jun 28, 2021
@blizzz

blizzz commented Jun 28, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@blizzz

blizzz commented Jun 28, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

artonge
artonge approved these changes Jun 28, 2021
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Pytal

Pytal commented Jun 28, 2021

Copy link
Copy Markdown
Member

Drone 🤷‍♂️

@blizzz

blizzz commented Jun 28, 2021

Copy link
Copy Markdown
MemberAuthor

Drone man_shrugging

unrelated

@blizzz
blizzz merged commit 73c5738 into masterJun 28, 2021
@blizzz
blizzz deleted the fix/25761/userexistsonldap-loop branch June 28, 2021 17:13
This was referenced Jun 28, 2021
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: ldapregression

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@Pytal@artonge