Skip to content

Fix for #26526 - #27731

Merged
skjnldsv merged 2 commits into
nextcloud:masterfrom
ZitronePlus:master
Oct 22, 2021
Merged

Fix for #26526 #27731
skjnldsv merged 2 commits into
nextcloud:masterfrom
ZitronePlus:master

Conversation

@ZitronePlus

@ZitronePlusZitronePlus commented Jun 30, 2021•
edited by szaimen
Loading

Copy link
Copy Markdown
Contributor

Fix#26526
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"

@ZitronePlus
Fix fornextcloud#26526
1d0a40a
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"
@szaimenszaimen added the 3. to review Waiting for reviews label Jun 30, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jun 30, 2021
@artonge

artonge commented Jul 1, 2021

Copy link
Copy Markdown
Collaborator

Nice and quick to review, thanks @ZitronePlus !

@artonge

artonge commented Jul 1, 2021•
edited
Loading

Copy link
Copy Markdown
Collaborator

Can you sign your commit ?

git commit --amend --no-edit --signoff
git push --force-with-lease origin master

@ZitronePlus
ZitronePlusforce-pushed the master branch 4 times, most recently from 5d32f37 to 5e02ac2CompareJuly 1, 2021 14:39
@ZitronePlus
Fix fornextcloud#26526
7d0dd31
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"
Signed-off-by: Tobias <scharft@hochschule-trier.de>
@Pytal

Pytal commented Jul 1, 2021

Copy link
Copy Markdown
Member

There are two commits now, you may want to

git reset --soft HEAD~2
git commit --signoff -m '<Your message>'
git push --force-with-lease origin master

@skjnldsv

skjnldsv commented Aug 18, 2021

Copy link
Copy Markdown
Member

/rebase

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 18, 2021
@szaimenszaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Aug 31, 2021
@szaimen

szaimen commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

@ZitronePlus any update here?
Do you mind addressing this comment #27731 (comment) ?
Otherwise creating a new PR with your changes is probably faster...

@skjnldsv

skjnldsv commented Sep 1, 2021

Copy link
Copy Markdown
Member

/rebase

@skjnldsvskjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv

skjnldsv commented Oct 15, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@ZitronePlus please rebase or allow us to edit this pr :)

@skjnldsv
skjnldsv merged commit b2c32b7 into nextcloud:masterOct 22, 2021
@welcome

welcomeBot commented Oct 22, 2021

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 22, 2021
@skjnldsvskjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

Database Versioncheck syntax error

6 participants

@ZitronePlus@artonge@Pytal@skjnldsv@szaimen@juliusknorr