Skip to content

[stable22] Fix in locking cache check - #27826

Merged
nickvergessen merged 1 commit into
stable22from
backport/27818/stable22
Jul 7, 2021
Merged

[stable22] Fix in locking cache check#27826
nickvergessen merged 1 commit into
stable22from
backport/27818/stable22

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Jul 6, 2021

Copy link
Copy Markdown

backport of #27818

@MichaIng@backportbot
Fix in locking cache check
e5fe200
The intention obviously was to check whether $lockingCacheClass is defined, and existing class, and available. It was however checked whether the $distributedCacheClass is an existing class, which would have caused an exception already in the previous distributed cache check.
Signed-off-by: MichaIng <micha@dietpi.com>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 22 milestone Jul 6, 2021
@MichaIng

MichaIng commented Jul 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member

How to tell @backportbot-nextcloud to assign stable22 backports to Nextcloud 22.0.1 milestone from now on?

Failed test sqlite-php7.3:

There was 1 failure:

  1. Test\Files\Cache\UpdaterLegacyTest::testWrite
    Failed asserting that 1625592437 is equal to 1625592438 or is greater than 1625592438.

Not related, of course.

@Pytal

Pytal commented Jul 6, 2021

Copy link
Copy Markdown
Member

How to tell @backportbot-nextcloud to assign stable22 backports to Nextcloud 22.0.1 milestone from now on?

Take a look at https://github.com/nextcloud/backportbot/blob/01b844872191d6d116b8e0d936807b3f00c46c14/lib/backport.js#L5-L31

@MichaIng

MichaIng commented Jul 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Okay I guess Nextcloud 22 was only used as it was still open and the first open matching major version milestone is used. I closed it in the meantime (and migrated all assigned PRs) so next stable22 backport should be assigned to the correct next minor release.

@nickvergessen

nickvergessen commented Jul 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Someone forgot to close the other milestone as part of the release procedure.

It's done already but not retroactive

@skjnldsv

skjnldsv commented Jul 7, 2021

Copy link
Copy Markdown
Member

Someone forgot to close the other milestone as part of the release procedure

The script failed

@nickvergessen

nickvergessen commented Jul 7, 2021

Copy link
Copy Markdown
Member

Failing test is unrelated

@nickvergessen
nickvergessen merged commit a0d6002 into stable22Jul 7, 2021
@nickvergessen
nickvergessen deleted the backport/27818/stable22 branch July 7, 2021 10:24
@skjnldsvskjnldsv mentioned this pull request Jul 26, 2021
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaIngMichaIngMichaIng approved these changes
@artongeartongeAwaiting requested review from artonge
@kesselbkesselbAwaiting requested review from kesselb
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@PytalPytalAwaiting requested review from Pytal

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

Nextcloud 22.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaIng@Pytal@nickvergessen@skjnldsv