Skip to content

Fix add group button - #27864

Merged
skjnldsv merged 1 commit into
masterfrom
bug/27435/add-group-button
Jul 8, 2021
Merged

Fix add group button#27864
skjnldsv merged 1 commit into
masterfrom
bug/27435/add-group-button

Conversation

@kesselb

@kesselbkesselb commented Jul 7, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#27435
Fix#27866

Peek.2021-07-07.19-46.mp4

@kesselb

kesselb commented Jul 7, 2021

Copy link
Copy Markdown
ContributorAuthor

/compile amend settings

@kesselb
kesselb requested review from artonge and skjnldsvJuly 7, 2021 17:45
LukasReschke
LukasReschke approved these changes Jul 7, 2021
View reviewed changes

@LukasReschkeLukasReschke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🥳 🎉

@kesselbkesselb added 3. to review Waiting for reviews bug labels Jul 7, 2021
@kesselb
kesselb requested a review from StCyrJuly 7, 2021 17:46
@kesselb

kesselb commented Jul 7, 2021

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the bug/27435/add-group-button branch from bf9bf65 to 5f5a6d5CompareJuly 7, 2021 17:58
@kesselb
kesselb requested a review from PytalJuly 7, 2021 18:26
Pytal
Pytal requested changes Jul 7, 2021
View reviewed changes
Comment threadapps/settings/src/views/Users.vue
@szaimenszaimen mentioned this pull request Jul 7, 2021
Closed
@skjnldsv

skjnldsv commented Jul 8, 2021

Copy link
Copy Markdown
Member

/backport to stable22

@skjnldsv

skjnldsv commented Jul 8, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Please rebase and compile, you need to remove the extra settings files

	deleted: apps/settings/js/vue-settings-users-7f4f43139d7b1af5f465.js
deleted: apps/settings/js/vue-settings-users-7f4f43139d7b1af5f465.js.map

@kesselb
Fix add group button
090f860
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@kesselb
kesselbforce-pushed the bug/27435/add-group-button branch from 5f5a6d5 to 090f860CompareJuly 8, 2021 14:43
@kesselb

kesselb commented Jul 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Please rebase and compile, you need to remove the extra settings files

	deleted: apps/settings/js/vue-settings-users-7f4f43139d7b1af5f465.js
deleted: apps/settings/js/vue-settings-users-7f4f43139d7b1af5f465.js.map

Done

@skjnldsv
skjnldsv merged commit 27fb46c into masterJul 8, 2021
@skjnldsv
skjnldsv deleted the bug/27435/add-group-button branch July 8, 2021 15:21
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2021
@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 8, 2021

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@kesselbkesselb mentioned this pull request Jul 8, 2021
Merged
@MichaIngMichaIng added this to the Nextcloud 23 milestone Jul 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasReschkeLukasReschkeLukasReschke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@PytalPytalPytal approved these changes
@artongeartongeAwaiting requested review from artonge
@StCyrStCyrAwaiting requested review from StCyr
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

NC 22, "Add group" Button just doing nothing Create group doesn't work (22.0.0 beta3)

7 participants

@kesselb@skjnldsv@nickvergessen@LukasReschke@Pytal@juliusknorr@MichaIng