Uh oh!
There was an error while loading. Please reload this page.
Fix comments file action sidebar opening - #27893
Merged
Merged
Conversation
julien-nc
commented
Jul 9, 2021
MemberAuthor
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
fix/comments-file-action
branch
from
July 9, 2021 10:37
c519b39 to
2e49a66Comparejulien-ncforce-pushed
the
fix/comments-file-action
branch
2 times, most recently
from
July 27, 2021 08:32
a21137c to
720d49eComparejulien-nc
commented
Jul 27, 2021
MemberAuthor
/backport to stable22 |
julien-nc
commented
Jul 27, 2021
MemberAuthor
/backport to stable21 |
julien-nc
commented
Jul 27, 2021
MemberAuthor
/compile amend / |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
nextcloud-botforce-pushed
the
fix/comments-file-action
branch
from
July 27, 2021 08:50
720d49e to
5914c5eCompareSigned-off-by: Julien Veyssier <eneiluj@posteo.net>
artonge
approved these changes
Jul 27, 2021
skjnldsv
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path is omitted when opening the sidebar after clicking on the comment file action. So it only works for files in root folder. Otherwise the sidebar fails to load the file data:
This can be backported to stable22 and stable21.
NC 20 is not affected by this bug.