Uh oh!
There was an error while loading. Please reload this page.
Show registered breadcrumb detail views in breadcrumb menu - #27946
Merged
Conversation
julien-nc
requested review from
artonge, jancborchardt, marcoambrosini, nimishavijay and szaimenJuly 13, 2021 12:35
julien-nc
commented
Jul 13, 2021
MemberAuthor
/compile amend / |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
enh/breadcrumb-detail-view-in-menu
branch
from
July 13, 2021 12:51
0069977 to
c035541Compareszaimen
removed their request for review
July 13, 2021 12:53
szaimen
approved these changes
Jul 13, 2021
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Looks good but didn't test
marcoambrosini
approved these changes
Jul 13, 2021
juliusknorr
commented
Jul 14, 2021
Member
Failures unrelated. |
julien-nc
commented
Jul 14, 2021
MemberAuthor
@juliushaertl Would you agree it makes sense to backport this to stable20, 21 and 22? |
juliusknorr
commented
Jul 14, 2021
Member
Fine by me, I'd rather consider that a bug for mobile anyways that the button would be no longer accessible. |
julien-nc
commented
Jul 14, 2021
MemberAuthor
/backport to stable20 |
julien-nc
commented
Jul 14, 2021
MemberAuthor
/backport to stable21 |
julien-nc
commented
Jul 14, 2021
MemberAuthor
/backport to stable22 |
The backport to stable22 failed. Please do this backport manually. |
The backport to stable21 failed. Please do this backport manually. |
This was referenced Jul 14, 2021
The backport to stable20 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it's consistent with the full breadcrumb.
This way the sharing icon (for example) is there and can be clicked to open the sidebar.
Tested on stable20, stable21 and stable22.
Make sure you set
debugtotrueinconfig/config.phpto try these changes.