Skip to content

Add autocompletion for password reset - #27949

Merged
artonge merged 1 commit into
nextcloud:masterfrom
CarlSchwan:work/carl/password-reset-autocomplete
Oct 25, 2021
Merged

Add autocompletion for password reset#27949
artonge merged 1 commit into
nextcloud:masterfrom
CarlSchwan:work/carl/password-reset-autocomplete

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Jul 13, 2021

Copy link
Copy Markdown
Member

Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.

See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.

Close#27885

Signed-off-by: Carl Schwan carl@carlschwan.eu

@szaimenszaimen added the 3. to review Waiting for reviews label Jul 13, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 13, 2021
@julien-nc

julien-nc commented Jul 13, 2021

Copy link
Copy Markdown
Member

@szaimen Are you sure you want to assign this PR? Maybe you wanted to request reviews? 😁

@szaimen

szaimen commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

Are you sure you want to assign this PR? Maybe you wanted to request reviews? 😁

You are right. I misclicked 😅

@CarlSchwanCarlSchwan mentioned this pull request Jul 13, 2021
Closed
julien-nc
julien-nc reviewed Jul 13, 2021
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This could also be done in login page and password reset page.
core/src/components/login/LoginForm.vue
core/src/components/login/UpdatePassword.vue

@CarlSchwan
CarlSchwanforce-pushed the work/carl/password-reset-autocomplete branch from 281a8fa to 66e1f88CompareJuly 13, 2021 16:09
@CarlSchwan

CarlSchwan commented Jul 13, 2021

Copy link
Copy Markdown
MemberAuthor

Nice! This could also be done in login page and password reset page.
core/src/components/login/LoginForm.vue
core/src/components/login/UpdatePassword.vue

Good idea :) Just did that and also unified the autocapitalize="none" autocorrect="off" behavior with the two places you linked. Not sure it's really needed since I expect browsers to be clever enough to not autocorrect password fields by default but at least it's consistent :)

@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 13, 2021
@CarlSchwan
CarlSchwanforce-pushed the work/carl/password-reset-autocomplete branch from 66e1f88 to 7344b2aCompareJuly 13, 2021 16:16
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 13, 2021
@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the work/carl/password-reset-autocomplete branch from 7344b2a to 1dd402bCompareJuly 13, 2021 16:34
@szaimen

This comment has been minimized.

Sign in to view
@szaimen

This comment has been minimized.

Sign in to view
Pytal
Pytal reviewed Jul 13, 2021
View reviewed changes
Comment threadcore/src/components/login/LoginForm.vue Outdated
@CarlSchwan
CarlSchwanforce-pushed the work/carl/password-reset-autocomplete branch from 923e45a to bf2304aCompareJuly 14, 2021 09:33
julien-nc
julien-nc requested changes Jul 14, 2021
View reviewed changes
Comment threadcore/src/components/login/UpdatePassword.vue Outdated
@julien-nc
julien-nc self-requested a review July 14, 2021 09:53
@julien-nc
julien-nc requested a review from PytalJuly 14, 2021 10:23
@szaimen
szaimenforce-pushed the work/carl/password-reset-autocomplete branch from cb6130b to 55e149dCompareJuly 14, 2021 22:15
@szaimen

szaimen commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

Solved the conflicting files. But I fear there is still the need to compile and push the js.
/compile amend / unfortunatlely didn't work the last times...

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the work/carl/password-reset-autocomplete branch from 55e149d to ab1f4a6CompareJuly 14, 2021 22:35
@szaimen
szaimenforce-pushed the work/carl/password-reset-autocomplete branch from ab1f4a6 to 4e3b538CompareJuly 14, 2021 22:39
@artonge

artonge commented Jul 15, 2021

Copy link
Copy Markdown
Collaborator

I compiled the files, but can't push on @CarlSchwan's branch :(

@CarlSchwan

CarlSchwan commented Jul 15, 2021

Copy link
Copy Markdown
MemberAuthor

I will compile the files and push them after lunch

@szaimen

szaimen commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

/rebase

@szaimen

szaimen commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

Unfortunately the fork seems to be still unpushable...

@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 31, 2021
@skjnldsvskjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv

skjnldsv commented Oct 22, 2021

Copy link
Copy Markdown
Member

@CarlSchwan rebase?

@CarlSchwanJulien Veyssier@Pytal
Add autocompletion for password reset
b7a35af
Using autocomplete="current-password" and autocomplete="new-password"
will help browser with integrated password managers to generate safe
password for the users.
See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element
and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete.
Also unify autocapitalize="none" autocorrect="off" behavior in a few
other places for password input fields.
Closenextcloud#27885
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-Authored-By: Julien Veyssier <eneiluj@posteo.net>
Co-Authored-By: Pytal <24800714+Pytal@users.noreply.github.com>
@CarlSchwan
CarlSchwanforce-pushed the work/carl/password-reset-autocomplete branch from 4e3b538 to b7a35afCompareOctober 22, 2021 10:18
@artonge
artonge merged commit 317d973 into nextcloud:masterOct 25, 2021
@skjnldsvskjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-ncjulien-ncjulien-nc approved these changes
@PytalPytalPytal approved these changes
@artongeartongeAwaiting requested review from artonge
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

2. developingWork in progress

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

Changing the password does not work properly on macOS/Safari

6 participants

@CarlSchwan@julien-nc@szaimen@artonge@skjnldsv@Pytal