Skip to content

Fix missing theming for login button - #27950

Merged
CarlSchwan merged 1 commit into
nextcloud:masterfrom
CarlSchwan:work/carl/login-button-theming
Jul 20, 2021
Merged

Fix missing theming for login button#27950
CarlSchwan merged 1 commit into
nextcloud:masterfrom
CarlSchwan:work/carl/login-button-theming

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Jul 13, 2021

Copy link
Copy Markdown
Member

Close#27495

image

Signed-off-by: Carl Schwan carl@carlschwan.eu

@szaimenszaimen added the 3. to review Waiting for reviews label Jul 13, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 13, 2021
@szaimen

This comment has been minimized.

Sign in to view
juliusknorr
juliusknorr reviewed Jul 13, 2021
View reviewed changes
Comment threadapps/theming/css/theming.scss Outdated
@CarlSchwan
CarlSchwanforce-pushed the work/carl/login-button-theming branch from 31f4364 to 9338817CompareJuly 14, 2021 14:55
@szaimen
szaimen requested a review from PytalJuly 14, 2021 22:05
Pytal
Pytal reviewed Jul 14, 2021
View reviewed changes
Comment threadapps/theming/css/theming.scss Outdated
jancborchardt
jancborchardt approved these changes Jul 19, 2021
View reviewed changes

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the gradient, nice work! :)

@juliusknorr

juliusknorr commented Jul 19, 2021

Copy link
Copy Markdown
Member

Sign-off message is missing on the second commit 😉

@CarlSchwan
Fix missing theming for login button
da68952
Closenextcloud#27495
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwanforce-pushed the work/carl/login-button-theming branch from 7449544 to da68952CompareJuly 20, 2021 08:07
@CarlSchwan
CarlSchwan merged commit 71109b7 into nextcloud:masterJul 20, 2021
@CarlSchwan

CarlSchwan commented Jul 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@CarlSchwan

CarlSchwan commented Jul 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@CarlSchwan

CarlSchwan commented Jul 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

/backport to stable22

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 20, 2021
Merged
@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

/backport to stable21

@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

/backport to stable20

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

/backport to stable21

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 20, 2021
Merged
@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

/backport to stable20

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 20, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardtjancborchardtjancborchardt approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@PytalPytalPytal approved these changes
@artongeartongeAwaiting requested review from artonge

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

"Log in" Button is not Themed

5 participants

@CarlSchwan@szaimen@juliusknorr@jancborchardt@Pytal