Skip to content

Improve notcreatable permissions hint - #27980

Merged
szaimen merged 1 commit into
masterfrom
enh/18683/improve-notcreatable-permissions-hint
Jul 15, 2021
Merged

Improve notcreatable permissions hint#27980
szaimen merged 1 commit into
masterfrom
enh/18683/improve-notcreatable-permissions-hint

Conversation

@szaimen

@szaimenszaimen commented Jul 15, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#18683

Before

Testvideos.-.Dateien.-.Nextcloud.-.Brave.2021-07-15.03-28-30.mp4

After

Testvideos.-.Dateien.-.Nextcloud.-.Brave.2021-07-15.12-36-21.mp4

Signed-off-by: szaimen szaimen@e.mail.de

@szaimenszaimen added the 2. developing Work in progress label Jul 15, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 15, 2021
@szaimen
szaimenforce-pushed the enh/18683/improve-notcreatable-permissions-hint branch from 63e1e4d to 3da023eCompareJuly 15, 2021 00:51
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2021
@szaimen
szaimen marked this pull request as ready for review July 15, 2021 01:32
Pytal
Pytal previously requested changes Jul 15, 2021
View reviewed changes
Comment threadapps/files/templates/list.php Outdated
@szaimen
szaimenforce-pushed the enh/18683/improve-notcreatable-permissions-hint branch 4 times, most recently from d03fb9c to 71c4f0fCompareJuly 15, 2021 02:56
@szaimen
szaimen requested a review from PytalJuly 15, 2021 03:03
artonge
artonge approved these changes Jul 15, 2021
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

juliusknorr
juliusknorr previously requested changes Jul 15, 2021
View reviewed changes
Comment threadapps/files/templates/list.php Outdated
@szaimen
szaimenforce-pushed the enh/18683/improve-notcreatable-permissions-hint branch 2 times, most recently from 7b6a66f to 3be614bCompareJuly 15, 2021 10:05
@szaimenszaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 15, 2021
@szaimen
szaimenforce-pushed the enh/18683/improve-notcreatable-permissions-hint branch from 3be614b to 86b3bcdCompareJuly 15, 2021 10:24
@szaimen
szaimen requested a review from juliusknorrJuly 15, 2021 10:37
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2021
@szaimen
szaimen dismissed Pytal’s stale reviewJuly 15, 2021 10:44

Because the requested changes were implemented.

@szaimen
szaimen dismissed juliusknorr’s stale reviewJuly 15, 2021 10:45

Because the requested changes were implemented.

@szaimen
szaimenforce-pushed the enh/18683/improve-notcreatable-permissions-hint branch 2 times, most recently from d557419 to fb1e161CompareJuly 15, 2021 10:57
Pytal
Pytal previously requested changes Jul 15, 2021
View reviewed changes
Comment threadcore/img/actions/alert-outline.svg Outdated
@szaimen
Improve notcreatable permissions hint
85b0df2
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
szaimenforce-pushed the enh/18683/improve-notcreatable-permissions-hint branch from 4ded592 to 85b0df2CompareJuly 15, 2021 19:00
@szaimen
szaimen requested a review from PytalJuly 15, 2021 19:01
@szaimen
szaimen dismissed Pytal’s stale reviewJuly 15, 2021 19:01

requested changes were implemented

@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement feature: files and removed 3. to review Waiting for reviews labels Jul 15, 2021
@szaimen
szaimen merged commit b3d5a57 into masterJul 15, 2021
@szaimen
szaimen deleted the enh/18683/improve-notcreatable-permissions-hint branch July 15, 2021 21:12
@szaimen

szaimen commented Jul 15, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimen

szaimen commented Jul 15, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@szaimen

szaimen commented Jul 15, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@szaimen

szaimen commented Jul 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Hm... is the backport bot dead?

@Pytal

Pytal commented Jul 15, 2021

Copy link
Copy Markdown
Member

Hm... is the backport bot dead?

@skjnldsv

@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 16, 2021
Merged
This was referenced Jul 16, 2021
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@PytalPytalPytal approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@nimishavijaynimishavijayAwaiting requested review from nimishavijay
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@marcoambrosinimarcoambrosiniAwaiting requested review from marcoambrosini
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.enhancementfeature: files

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

[mobile layout] problem with "cannot upload a file here" and icon in the top right corner

4 participants

@szaimen@Pytal@juliusknorr@artonge