Skip to content

some multiselect design fixes - #27995

Merged
juliusknorr merged 1 commit into
masterfrom
enh/noid/multiselect-design-fixes
Jul 16, 2021
Merged

some multiselect design fixes#27995
juliusknorr merged 1 commit into
masterfrom
enh/noid/multiselect-design-fixes

Conversation

@szaimen

@szaimenszaimen commented Jul 15, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Multiselect view

BeforeAfter
imageimage
Other screenshots

Normal list view

BeforeAfter
imageimage

Signed-off-by: szaimen szaimen@e.mail.de

@szaimenszaimen added the 2. developing Work in progress label Jul 15, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 15, 2021
@szaimen
szaimenforce-pushed the enh/noid/multiselect-design-fixes branch 2 times, most recently from 2bdaecf to 67fe287CompareJuly 15, 2021 15:07
@szaimen
some multiselect design fixes
f4db7cb
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
szaimenforce-pushed the enh/noid/multiselect-design-fixes branch from 67fe287 to f4db7cbCompareJuly 15, 2021 15:09
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 15, 2021
@szaimen
szaimen marked this pull request as ready for review July 15, 2021 15:45
artonge
artonge reviewed Jul 15, 2021
View reviewed changes

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it look good on mobile too ?

@szaimen

szaimen commented Jul 15, 2021

Copy link
Copy Markdown
ContributorAuthor

On mobile nothing has changed:

BeforeAfter
imageimage

@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 16, 2021
@juliusknorr
juliusknorr merged commit 2766df9 into masterJul 16, 2021
@juliusknorr
juliusknorr deleted the enh/noid/multiselect-design-fixes branch July 16, 2021 12:28
@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 16, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 16, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 16, 2021

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@szaimenszaimen mentioned this pull request Jul 16, 2021
Merged
@szaimen

szaimen commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

backport to stable22 in #28011
I am not bothering to backport to stable21 and stable20 since the backport bot has failed...

@szaimenszaimen mentioned this pull request Jul 16, 2021
Closed
@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 20, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 20, 2021
Closed
@szaimen

szaimen commented Jul 20, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 20, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge left review comments
@skjnldsvskjnldsvskjnldsv approved these changes
@PytalPytalPytal approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@nimishavijaynimishavijayAwaiting requested review from nimishavijay
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.enhancementfeature: files

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

5 participants

@szaimen@artonge@skjnldsv@Pytal@juliusknorr