Uh oh!
There was an error while loading. Please reload this page.
Gracefully handle smb acls for users without a domain - #28062
Merged
Conversation
MemberAuthor
@icewind1991 Or should we ignore all "users" with no domain in ACLs? I'm not sure what is the right call here. Excerpt from the data leading to the error: {
"acls": {
"DOMAIN\\user1": {
"__class__": "Icewind\\SMB\\ACL"
},
"DOMAIN\\user2": {
"__class__": "Icewind\\SMB\\ACL"
},
"Everyone": {
"__class__": "Icewind\\SMB\\ACL"
},
"Other User": {
"__class__": "Icewind\\SMB\\ACL"
}
}
} |
szaimen
commented
Jul 20, 2021
Contributor
He is on vacations currently... |
st3inyforce-pushed
the
fix/27809/smb-acl-users-without-domain
branch
from
July 28, 2021 06:58
ba7a9c8 to
d1faffaComparest3iny
marked this pull request as ready for review
July 28, 2021 06:59
juliusknorr
commented
Aug 11, 2021
Member
icewind1991
approved these changes
Aug 11, 2021
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3inyforce-pushed
the
fix/27809/smb-acl-users-without-domain
branch
from
August 13, 2021 07:44
d1faffa to
2e53cf4Comparest3iny
commented
Aug 13, 2021
MemberAuthor
/backport to stable20 |
st3iny
commented
Aug 13, 2021
MemberAuthor
/backport to stable21 |
st3iny
commented
Aug 13, 2021
MemberAuthor
/backport to stable22 |
This was referenced Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#27809
Currently, checking ACLs of SMB storages fails if the user in the ACL has no domain.