Skip to content

Admin Audit - Sharing: createShare - report the full path - #28075

Merged
juliusknorr merged 1 commit into
masterfrom
enh/noid/admin_audit-report-full-path
Jul 26, 2021
Merged

Admin Audit - Sharing: createShare - report the full path#28075
juliusknorr merged 1 commit into
masterfrom
enh/noid/admin_audit-report-full-path

Conversation

@szaimen

@szaimenszaimen commented Jul 20, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

As the Admin of a Nextcloud instance, I want to see the full path to a file/folder that is shared in the admin audit log and not the theoretical position where the file/folder might be found after sharing. Beeing able to see the full path is a much more useful information because you can much better see where the file/folder is initialy located.

Signed-off-by: szaimen szaimen@e.mail.de

@szaimenszaimen added the 2. developing Work in progress label Jul 20, 2021
@szaimen
szaimenforce-pushed the enh/noid/admin_audit-report-full-path branch 18 times, most recently from 493bf85 to 4f364caCompareJuly 21, 2021 13:54
@szaimenszaimen changed the title Try to implement reporting the full pathAdmin Audit - Sharing: createShare - report the full pathJul 21, 2021
@szaimen
szaimen marked this pull request as ready for review July 21, 2021 14:06
@szaimenszaimen added 3. to review Waiting for reviews enhancement feature: admin audit and removed 2. developing Work in progress labels Jul 21, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 21, 2021
@szaimen
szaimen requested a review from wiswedelJuly 21, 2021 14:09
@szaimen

szaimen commented Jul 21, 2021

Copy link
Copy Markdown
ContributorAuthor

Failing test is unrelated

@szaimen

szaimen commented Jul 22, 2021

Copy link
Copy Markdown
ContributorAuthor

/rebase

@szaimen
Admin Audit - Sharing: createShare - report the full path
4570bb4
Signed-off-by: szaimen <szaimen@e.mail.de>
@github-actions
github-actionsBotforce-pushed the enh/noid/admin_audit-report-full-path branch from 4f364ca to 4570bb4CompareJuly 22, 2021 14:20
@szaimenszaimen closed this Jul 24, 2021
@szaimenszaimen reopened this Jul 24, 2021
@juliusknorr

juliusknorr commented Jul 26, 2021

Copy link
Copy Markdown
Member

Failure unrelated

@juliusknorr
juliusknorr merged commit b31c08e into masterJul 26, 2021
@juliusknorr
juliusknorr deleted the enh/noid/admin_audit-report-full-path branch July 26, 2021 10:35
@szaimen

szaimen commented Jul 26, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@juliusknorr

juliusknorr commented Jul 26, 2021

Copy link
Copy Markdown
Member

I'd vote against backports since external log parsing might require adjustments through the changed format.

@szaimen

szaimen commented Jul 26, 2021

Copy link
Copy Markdown
ContributorAuthor

I'd vote against backports since external log parsing might require adjustments through the changed format.

Thats a good point but what about backporting to stable22?

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 26, 2021

Copy link
Copy Markdown

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 26, 2021

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Jul 26, 2021

Copy link
Copy Markdown

The backport to stable21 failed. Please do this backport manually.

@szaimen

szaimen commented Jul 26, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 26, 2021
Merged
@juliusknorr

juliusknorr commented Jul 26, 2021

Copy link
Copy Markdown
Member

Fine by me since it will be 21.1, but would be good to add to #27846 as a note

@szaimenszaimen mentioned this pull request Jul 26, 2021
Closed
@szaimen

szaimen commented Jul 26, 2021

Copy link
Copy Markdown
ContributorAuthor

but would be good to add to #27846 as a note

Added it under Behavorial changes

Do we have somethings like this for 22.1, too?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@kesselbkesselbAwaiting requested review from kesselb
@wiswedelwiswedelAwaiting requested review from wiswedel

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: admin audit

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

3 participants

@szaimen@juliusknorr@skjnldsv