Uh oh!
There was an error while loading. Please reload this page.
Make sure that the dav propfind plugins always use the proper user id - #28084
Merged
Conversation
juliusknorr
commented
Jul 21, 2021
MemberAuthor
/backport to stable22 |
Member
in case anyone wondering, this should fix also an unknown bug of shared files not being displayed in the android app when using LDAP |
juliusknorrforce-pushed
the
bugfix/noid/dav-user-id
branch
from
July 21, 2021 13:09
cb3d1ac to
650d297Compareartonge
approved these changes
Jul 21, 2021
Pytal
approved these changes
Jul 21, 2021
Pytal
commented
Jul 21, 2021
Member
CI 🤔 |
ArtificialOwl
approved these changes
Jul 22, 2021
ArtificialOwl
left a comment
Member
There was a problem hiding this comment.
looks like it fixes the original issue
For old android versions it could happen that the requests are performed with a login name instead of the actual user id, so before this change the property methods used the wrong value for fetching their information Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/dav-user-id
branch
from
July 22, 2021 10:28
650d297 to
6909ce6Compareszaimen
commented
Jul 22, 2021
Contributor
Not sure if the failing tests are unrelated... |
skjnldsv
commented
Jul 23, 2021
Member
Doesn't seems related no |
The backport to stable22 failed. Please do this backport manually. |
szaimen
commented
Jul 24, 2021
Contributor
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For old android versions it could happen that the requests are performed
with a login name instead of the actual user id, so before this change
the property methods used the wrong value for fetching their information
Found in nextcloud/circles#672