Uh oh!
There was an error while loading. Please reload this page.
[stable20] hide download button for public preview of audio files - #28096
Merged
Conversation
When the option to hide downloads was selected at public link creation, the download button can be hidden by the audio html attribute controlsList="nodownload" Signed-off-by: Florian Storz <florian.storz@devlix.de>
PR contains discussion about the implementation with pros and cons Signed-off-by: Florian Storz <florian.storz@devlix.de>
Signed-off-by: Florian Storz <florian.storz@devlix.de>
szaimen
approved these changes
Jul 21, 2021
Pytal
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #27674