Skip to content

Fix dark theme in file exists dialog - #28101

Merged
szaimen merged 1 commit into
masterfrom
fix/22748/fix-file-exists-dialog-dark-theme
Jul 22, 2021
Merged

Fix dark theme in file exists dialog#28101
szaimen merged 1 commit into
masterfrom
fix/22748/fix-file-exists-dialog-dark-theme

Conversation

@szaimen

@szaimenszaimen commented Jul 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix#22748

BeforeAfter
imageimage

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen
Fix dark theme in file exists dialog
bf4f91b
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimenszaimen added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Jul 21, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 21, 2021
@szaimen

szaimen commented Jul 21, 2021

Copy link
Copy Markdown
ContributorAuthor

Failing test is unrelated

@szaimen

szaimen commented Jul 22, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimen

szaimen commented Jul 22, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@szaimen

szaimen commented Jul 22, 2021

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@szaimenszaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2021
julien-nc
julien-nc approved these changes Jul 22, 2021
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@szaimen

szaimen commented Jul 22, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks! :) @eneiluj do you have force-merge rights?

@julien-nc

julien-nc commented Jul 22, 2021

Copy link
Copy Markdown
Member

@szaimen Nowpe 😁

@szaimen

szaimen commented Jul 22, 2021

Copy link
Copy Markdown
ContributorAuthor

Nowpe 😁

Okay

@szaimen

szaimen commented Jul 22, 2021

Copy link
Copy Markdown
ContributorAuthor

Merging because failing test is unrelated

@szaimen
szaimen merged commit dd4668f into masterJul 22, 2021
@szaimen
szaimen deleted the fix/22748/fix-file-exists-dialog-dark-theme branch July 22, 2021 10:37
This was referenced Jul 22, 2021
Merged
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 22, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@julien-ncjulien-ncjulien-nc approved these changes
@PytalPytalPytal approved these changes
@nimishavijaynimishavijayAwaiting requested review from nimishavijay
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugdesignDesign, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

Dark theme : black on black in file conflict popup

4 participants

@szaimen@julien-nc@artonge@Pytal