Skip to content

add an option to the multiple files selected actions to add and remov… - #28133

Merged
skjnldsv merged 1 commit into
masterfrom
feat/tag_multiple_files_at_once
Jul 23, 2021
Merged

add an option to the multiple files selected actions to add and remov…#28133
skjnldsv merged 1 commit into
masterfrom
feat/tag_multiple_files_at_once

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jul 23, 2021•
edited
Loading

Copy link
Copy Markdown
Member

image

@skjnldsv
skjnldsvforce-pushed the feat/tag_multiple_files_at_once branch 2 times, most recently from 8f8a0d0 to e0573ecCompareJuly 23, 2021 13:12
@skjnldsv

skjnldsv commented Jul 23, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@skjnldsv
skjnldsv marked this pull request as ready for review July 23, 2021 13:27
@skjnldsvskjnldsv added this to the Nextcloud 23 milestone Jul 23, 2021
@skjnldsv
skjnldsvforce-pushed the feat/tag_multiple_files_at_once branch from e0573ec to b830487CompareJuly 23, 2021 13:29
PVince81
PVince81 reviewed Jul 23, 2021
View reviewed changes
Comment threadapps/files/js/filelist.js Outdated
Comment threadapps/files/js/filelist.js Outdated
@skjnldsv
skjnldsvforce-pushed the feat/tag_multiple_files_at_once branch from b830487 to 8f9588fCompareJuly 23, 2021 13:33
julien-nc
julien-nc approved these changes Jul 23, 2021
View reviewed changes

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

Not a big deal but the tag_multiple_files_container disappears when clicking on Please select tag(s) to add to the selection.

PVince81
PVince81 reviewed Jul 23, 2021
View reviewed changes
Comment threadapps/files/js/filelist.js
PVince81
PVince81 reviewed Jul 23, 2021
View reviewed changes
Comment threadapps/files/js/filelist.js Outdated
Comment threadapps/files/js/filelist.js Outdated
Comment threadapps/files/js/filelist.js Outdated
Comment threadapps/files/js/filelist.js Outdated
Comment threadapps/files/js/filelist.js
PVince81
PVince81 approved these changes Jul 23, 2021
View reviewed changes

@PVince81PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the job 👍

@PVince81PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 23, 2021
@skjnldsv

skjnldsv commented Jul 23, 2021

Copy link
Copy Markdown
MemberAuthor

Not a big deal but the tag_multiple_files_container disappears when clicking on Please select tag(s) to add to the selection.

Yes, it hides while adding in the background. I think we can do better, but I would do it when properly rewriting this feature to vue?

@skjnldsv
skjnldsvforce-pushed the feat/tag_multiple_files_at_once branch from dcc0786 to edc77b7CompareJuly 23, 2021 15:42
Roland Scheidel@skjnldsv
add an option to the multiple files selected actions to add and remov…
c5af910
…e tags from multiple files at once
Signed-off-by: Roland Scheidel <kontakt@scheidel.at>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the feat/tag_multiple_files_at_once branch from edc77b7 to c5af910CompareJuly 23, 2021 15:47
@julien-nc

julien-nc commented Jul 23, 2021

Copy link
Copy Markdown
Member

Not a big deal but the tag_multiple_files_container disappears when clicking on Please select tag(s) to add to the selection.

Yes, it hides while adding in the background. I think we can do better, but I would do it when properly rewriting this feature to vue?

Yeah sure.
Just to be clear thoug: The selector disappears even if no tag was added/removed, just when one click on the label.

@skjnldsv
skjnldsv merged commit 6817ba1 into masterJul 23, 2021
@skjnldsv
skjnldsv deleted the feat/tag_multiple_files_at_once branch July 23, 2021 16:25
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 23, 2021
Merged
@skjnldsvskjnldsv mentioned this pull request Jul 23, 2021
Closed
@siccovansassiccovansas mentioned this pull request Jul 23, 2021
Closed
17 tasks
@skjnldsvskjnldsv mentioned this pull request Aug 11, 2021
Closed
@jancborchardtjancborchardt mentioned this pull request Aug 16, 2021
Closed
2 tasks
@jancborchardt

jancborchardt commented Aug 16, 2021

Copy link
Copy Markdown
Member

Two follow-up problems with this feature, opened a new issue: #28456

@duckdiver

duckdiver commented Oct 1, 2021

Copy link
Copy Markdown

nice feature to tag multiple files.
Now it would also be nice to share files by tags or mutliple files at once from a folder, which is nowadays not possible.
does that make sence?
do you also recognize tags from external programs eg. qnap photostation?

@Spartachetto

Spartachetto commented Oct 6, 2021•
edited
Loading

Copy link
Copy Markdown

@duckdiver first of all it is not advised to ask for different features in one issue dealing with a specific feature.

Second, I remember a really old feature request about sharing multiple files. It is #1291

@artongeartonge mentioned this pull request Apr 27, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-ncjulien-ncjulien-nc approved these changes
@PVince81PVince81PVince81 approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt
@artongeartongeAwaiting requested review from artonge
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@szaimenszaimenAwaiting requested review from szaimen
@PytalPytalAwaiting requested review from Pytal

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: filesfeature: tags

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv@julien-nc@jancborchardt@duckdiver@Spartachetto@PVince81