Fix sort function of files multiple selection actions

[julien-nc]

Javascript array sort function must return -1, 0 or 1 😁.

This can be backported to stable22 only.

[julien-nc]

/backport to stable22

[skjnldsv]

Yes and no.
Sort allows upper and lower values
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort

varnumbers=[4,2,5,1,3];numbers.sort(function(a,b){returna-b;});console.log(numbers);// [1, 2, 3, 4, 5]

If compareFunction(a, b) returns a value > than 0, sort b before a.
If compareFunction(a, b) returns a value ≤ 0, leave a and b in the same order.

Not sure it's really necessary

[julien-nc]

Not sure it's really necessary

I think it is because, currently, sort function return values are wrong as a boolean is returned. So the array is actually not sorted, its order stays the same.

And sorry for the poor description of what's expected of the sort function 😁

[skjnldsv]

then shouldn't it be a.order - b.order

[julien-nc]

Well what if the order is undefined? (which is the case for the recent tag multiselect action 😁)

We would need something like

return(a.order||1000)-(b.order||1000)

to make sure the ones without order are placed at the end.

[skjnldsv]

If the order is undefined it's most likely going to break somewhere else, no? xD
But yes, I'm fine with whatever you want, let's get this in! 🚀

[artonge]

What's the state here ?

Just tested and:

[1,5,-1,undefined,-100].sort((a,b)=>a-b)Array(5)[-100,-1,1,5,undefined][1,5,-1,undefined,-100].sort((a,b)=>b-a)Array(5)[5,1,-1,-100,undefined]

So this should be fine I guess as undefines are at the end

returnb.order-a.order

[julien-nc]

@artonge Very true, thanks. Let's roll.

What's the state here ?

State is now yours to decide 😁.