Skip to content

Improve auto expiration hint for trashbin and file versions - #28211

Merged
szaimen merged 1 commit into
masterfrom
fix/27496/improve-auto-expiration-hint
Aug 16, 2021
Merged

Improve auto expiration hint for trashbin and file versions#28211
szaimen merged 1 commit into
masterfrom
fix/27496/improve-auto-expiration-hint

Conversation

@szaimen

Copy link
Copy Markdown
Contributor

Fix#27496

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen

Copy link
Copy Markdown
ContributorAuthor

Failed test is unrelated, afaics

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable21

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable20

@artonge

artonge commented Jul 28, 2021

Copy link
Copy Markdown
Collaborator

Does this mean that files will always expire and there is no way to keep the files in the trash forever?

@szaimen

Copy link
Copy Markdown
ContributorAuthor

Does this mean that files will always expire and there is no way to keep the files in the trash forever?

Actually, I don't know. lets cc @PVince81 and @icewind1991 on this

Comment threadapps/files_trashbin/lib/Command/ExpireTrash.php Outdated
Comment threadapps/files_versions/lib/Command/ExpireVersions.php Outdated
@Pytal

Copy link
Copy Markdown
Member

@PytalPytal changed the title Improve auto expiration hintImprove auto expiration hint for trashbin and file versionsJul 29, 2021
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: Pytal <24800714+Pytal@users.noreply.github.com>
@szaimen
szaimenforce-pushed the fix/27496/improve-auto-expiration-hint branch from cc4173f to 98102bfCompareAugust 8, 2021 18:41
@szaimen

Copy link
Copy Markdown
ContributorAuthor

Thanks for the good suggestions @Pytal :)

@szaimen
szaimen requested a review from PytalAugust 8, 2021 18:42
@szaimen

szaimen commented Aug 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Failing test is unrelated

@PVince81

Copy link
Copy Markdown
Member

Does this mean that files will always expire and there is no way to keep the files in the trash forever?

Actually, I don't know. lets cc @PVince81 and @icewind1991 on this

according to config.sample.php, it's possible to disable this with: trashbin_retention_obligation => 'disabled'.
not sure how those settings map to the CLI output

@szaimen

szaimen commented Aug 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for the approval Pytal! :)

The failing test is unrelated, afaics.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"No expiry configured." when AUTO is configured

5 participants

@szaimen@artonge@Pytal@PVince81@solracsf