Skip to content

Fix too many file download notifications when watching a video - #28227

Merged
szaimen merged 1 commit into
masterfrom
enh/noid/report-remoteAddress
Mar 7, 2022
Merged

Fix too many file download notifications when watching a video#28227
szaimen merged 1 commit into
masterfrom
enh/noid/report-remoteAddress

Conversation

@szaimen

@szaimenszaimen commented Jul 29, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

@szaimenszaimen added the 2. developing Work in progress label Jul 29, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Jul 29, 2021
@szaimen
szaimenforce-pushed the enh/noid/report-remoteAddress branch 18 times, most recently from 34bbc6e to c202fb0CompareJuly 29, 2021 11:22
@szaimenszaimen changed the title Allow to report the remoteAddressReport the remoteAddress for download activities and merge equal onesJul 29, 2021
@szaimen

szaimen commented Jul 29, 2021

Copy link
Copy Markdown
ContributorAuthor

I think the failing test is unrelated

@szaimen
szaimen marked this pull request as ready for review July 29, 2021 18:40
@szaimen
szaimen requested review from a team and nickvergessenJuly 29, 2021 18:40
nickvergessen
nickvergessen requested changes Jul 29, 2021
View reviewed changes
Comment threadapps/files_sharing/lib/Activity/Providers/Downloads.php Outdated
Comment threadapps/files_sharing/lib/Controller/ShareController.php Outdated
@szaimen
szaimenforce-pushed the enh/noid/report-remoteAddress branch from 3563d02 to 648efdbCompareMarch 7, 2022 13:32
nickvergessen
nickvergessen reviewed Mar 7, 2022
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareController.php Outdated
nickvergessen
nickvergessen reviewed Mar 7, 2022
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareController.php Outdated
@szaimen
szaimenforce-pushed the enh/noid/report-remoteAddress branch from 648efdb to d78c2ecCompareMarch 7, 2022 13:40
@szaimenszaimen added 3. to review Waiting for reviews bug and removed 2. developing Work in progress pending documentation This pull request needs an associated documentation update enhancement labels Mar 7, 2022
@szaimen
szaimen requested review from Pytal, juliusknorr and skjnldsv and removed request for nickvergessenMarch 7, 2022 13:55
@szaimen

szaimen commented Mar 7, 2022

Copy link
Copy Markdown
ContributorAuthor

/backport to stable23

@szaimen

szaimen commented Mar 7, 2022

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimen

This comment was marked as resolved.

Sign in to view
@szaimen

szaimen commented Mar 7, 2022

Copy link
Copy Markdown
ContributorAuthor

/rebase for checking if all checks pass

@szaimen
Fix too many file download notifications when watching a video
ccd0887
Signed-off-by: szaimen <szaimen@e.mail.de>
@nextcloud-command
nextcloud-commandforce-pushed the enh/noid/report-remoteAddress branch from d78c2ec to ccd0887CompareMarch 7, 2022 19:50
@szaimen
szaimen merged commit 019117c into masterMar 7, 2022
@szaimen
szaimen deleted the enh/noid/report-remoteAddress branch March 7, 2022 20:48
This was referenced Mar 7, 2022
Merged
Merged
@szaimenszaimen mentioned this pull request Nov 22, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@PytalPytalPytal approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@PVince81PVince81Awaiting requested review from PVince81
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: activity and notification

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Hundreds of notifications when a shared video is played in the browser Shared videos count multiple times

8 participants

@szaimen@kesselb@wagnbeu0@Karem-sobhy@nickvergessen@juliusknorr@skjnldsv@Pytal