Uh oh!
There was an error while loading. Please reload this page.
Fix missing label of Search function - #28238
Merged
Merged
Conversation
marcoambrosini
approved these changes
Jul 29, 2021
marcoambrosini
left a comment
Member
There was a problem hiding this comment.
Code seems ok but can't test atm, so...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
jancborchardtforce-pushed
the
accessibility/search
branch
from
July 29, 2021 15:21
796d983 to
310cec4Comparejancborchardt
commented
Jul 29, 2021
MemberAuthor
Now works thanks to @juliushaertl! The issue was that due to the |
jancborchardt
commented
Jul 29, 2021
MemberAuthor
/backport to stable22 |
jancborchardt
commented
Jul 29, 2021
MemberAuthor
/backport to stable21 |
jancborchardt
commented
Jul 29, 2021
MemberAuthor
/backport to stable20 |
This was referenced Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining issue reported by Lighthouse by moving the aria-label from the icon to the link itself.