Uh oh!
There was an error while loading. Please reload this page.
Add h2 to personal info page, fixing accessibility issue - #28240
Merged
Conversation
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
marcoambrosini
approved these changes
Jul 29, 2021
jancborchardt
commented
Jul 29, 2021
MemberAuthor
/backport to stable22 |
jancborchardt
commented
Jul 29, 2021
MemberAuthor
/backport to stable21 |
jancborchardt
commented
Jul 29, 2021
MemberAuthor
/backport to stable20 |
jancborchardt
commented
Jul 29, 2021
MemberAuthor
Drone failure looks unrelated? |
juliusknorr
approved these changes
Jul 30, 2021
This was referenced Jul 30, 2021
The backport to stable20 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last thing reported by Lighthouse on the personal settings page – there were h3 elements but no h2. Fixed by inserting a hidden-visually h2.
Please review @nextcloud/accessibility
Proposing backport to 20–22 as well since the string already exists in the navigation and should not require further translations, right?