Skip to content

Bump sinon from 5.0.7 to 11.1.2 in /build - #28264

Closed
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/build/sinon-11.1.2
Closed

Bump sinon from 5.0.7 to 11.1.2 in /build#28264
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/build/sinon-11.1.2

Conversation

@dependabot

@dependabotdependabotBot commented on behalf of githubJul 31, 2021

Copy link
Copy Markdown
Contributor

Bumps sinon from 5.0.7 to 11.1.2.

Changelog

Sourced from sinon's changelog.

11.1.1 / 2021-05-26

  • Fix #2379 by using v7 of supports-color

11.1.0 / 2021-05-25

  • Add sinon.promise() implementation (#2369)
  • Set wrappedMethod on getters/setters (#2378)
  • [Docs] Update fake-server usage & descriptions (#2365)
  • Fake docs improvement (#2360)
  • Update nise to 5.1.0 (fixed #2318)

11.0.0 / 2021-05-24

  • Explicitly use samsam 6.0.2 with fix for #2345
  • Update most packages (#2371)
  • Update compatibility docs (#2366)
  • Update packages (includes breaking fake-timers change, see #2352)
  • Warn of potential memory leaks (#2357)
  • Fix clock test errors

10.0.1 / 2021-04-08

  • Upgrade sinon components (bumps y18n to 4.0.1)
  • Bump y18n from 4.0.0 to 4.0.1

10.0.0 / 2021-03-22

  • Upgrade nise to 4.1.0
  • Use @​sinonjs/eslint-config@​4 => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari

9.2.4 / 2021-01-23

  • Upgrade @​sinonjs/samsam@​5.3.1

9.2.3 / 2021-01-06

  • Use util.inspect for formatting human readable output (this retires @​sinonjs/formatio)

9.2.2 / 2020-12-11

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@MichaIngMichaIng added this to the Nextcloud 23 milestone Jul 31, 2021
@MichaIngMichaIng added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 31, 2021
@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/build/sinon-11.1.2 branch from 8bd762f to 1bc95cbCompareSeptember 2, 2021 21:28
@MichaIng

Copy link
Copy Markdown
Member

@dependabot rebase

@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/build/sinon-11.1.2 branch from 1bc95cb to fd0bfb3CompareSeptember 3, 2021 13:16
@MichaIng

Copy link
Copy Markdown
Member

jsunit error:

Chrome Headless 93.0.4577.0 (Linux x86_64) ERROR
Uncaught TypeError: By RFC7230, section 3.2.4, header values should be strings. Got object
at build/lib/node_modules/sinon/pkg/sinon.js:15832:17
TypeError: By RFC7230, section 3.2.4, header values should be strings. Got object
at FakeXMLHttpRequest.setRequestHeader (build/lib/node_modules/sinon/pkg/sinon.js:15832:23)
at dav.Client.request (core/js/dist/main.js:310:24446)
at dav.Client.propFind (core/js/dist/main.js:310:22947)
at core/js/dist/main.js:27:34903
at Object.davCall (core/js/dist/main.js:27:35176)
at i.Object.assign.davSync [as sync] (core/js/dist/main.js:27:36778)
at i.fetch (core/js/dist/main.js:160:136364)
at i.fetch (core/js/dist/systemtags.js:56:731)
at Object.init (apps/systemtags/js/admin.js:38:20)
at apps/systemtags/js/admin.js:182:23
03 09 2021 13:20:23.452:WARN [web-server]: 404: /icon-mail
03 09 2021 13:20:23.454:WARN [web-server]: 404: /icon-info
Chrome Headless 93.0.4577.0 (Linux x86_64): Executed 4 of 815 ERROR (0.037 secs / 0.026 secs)
Contacts menu
✗ shows an error message when loading the contacts data fails
Expected spy error to have been called once. It was called 2 times.
at core/js/tests/specs/contactsmenuSpec.js:76:26

@MichaIng

MichaIng commented Sep 22, 2021

Copy link
Copy Markdown
Member

Related commit which leads to this error: sinonjs/nise@a6790f0

So the DAV client (or tags app?) needs to set header values as strings.

Probably OC.requestToken isn't assured to be a string? https://github.com/nextcloud/server/blob/master/core/src/OC/backbone-webdav.js#L241

@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/build/sinon-11.1.2 branch from fd0bfb3 to 2e85af7CompareOctober 6, 2021 14:11
Bumps [sinon](https://github.com/sinonjs/sinon) from 5.0.7 to 11.1.2.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/commits)
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabotBotforce-pushed the dependabot/npm_and_yarn/build/sinon-11.1.2 branch from 2e85af7 to cb98281CompareOctober 11, 2021 13:21
@skjnldsvskjnldsv mentioned this pull request Oct 13, 2021
@dependabot@github

dependabotBot commented on behalf of githubNov 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Superseded by #29571.

@dependabotdependabotBot closed this Nov 6, 2021
@dependabot
dependabotBot deleted the dependabot/npm_and_yarn/build/sinon-11.1.2 branch November 6, 2021 02:04
@MichaIngMichaIng removed this from the Nextcloud 24 milestone Jan 3, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaIng@skjnldsv