Skip to content

Allow to open any app in a standalone window - #28459

Merged
szaimen merged 1 commit into
masterfrom
enh/noid/improve-webmanifest-2
Aug 25, 2021
Merged

Allow to open any app in a standalone window#28459
szaimen merged 1 commit into
masterfrom
enh/noid/improve-webmanifest-2

Conversation

@szaimen

@szaimenszaimen commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

Description

This change allows to start every app in its own standalone window which is very cool for some apps that you might want to access directly from the startmenu of your OS without needing to open the browser and clicking on a favorite or app inside Nextcloud first. It applies to any app if the theming app is enabled.

Example: Files app

BeforeAfter
imageimage
imageimage

Standalone window will afterwards look like this

image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimenszaimen added the 2. developing Work in progress label Aug 16, 2021
@szaimenszaimen added this to the Nextcloud 23 milestone Aug 16, 2021
@szaimen
szaimenforce-pushed the enh/noid/improve-webmanifest-2 branch 8 times, most recently from af9f345 to f1eeb3dCompareAugust 23, 2021 11:42
@szaimen
szaimen marked this pull request as ready for review August 23, 2021 12:32
@szaimenszaimen added 3. to review Waiting for reviews enhancement feature: theming and removed 2. developing Work in progress labels Aug 23, 2021
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable22

@szaimenszaimen changed the title improve webmanifestAllow to open any app in a standalone windowAug 23, 2021

@julien-ncjulien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Works fine with an empty app summary.

@julien-nc

Copy link
Copy Markdown
Member

Additional hint to try this PR:
To add a website as an app on Chromium based browsers, open the hamburger menu -> more tools -> create shortcut

@szaimen
szaimen requested a review from a teamAugust 23, 2021 13:46
@szaimen
szaimenforce-pushed the enh/noid/improve-webmanifest-2 branch 4 times, most recently from e8cbb67 to 544f2dfCompareAugust 23, 2021 17:06
Comment threadapps/theming/lib/Controller/ThemingController.php Outdated
Comment threadapps/theming/lib/Controller/ThemingController.php Outdated
Comment threadapps/theming/lib/Controller/ThemingController.php
juliusknorr
juliusknorr previously requested changes Aug 23, 2021

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@bessw

This comment has been minimized.

@szaimen

This comment has been minimized.

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
szaimenforce-pushed the enh/noid/improve-webmanifest-2 branch from 544f2df to 0758e02CompareAugust 24, 2021 09:42
@szaimen

szaimen commented Aug 24, 2021

Copy link
Copy Markdown
ContributorAuthor

@juliushaertl are you fine when I merge this or is there still something that needs to be addressed?

@szaimen

Copy link
Copy Markdown
ContributorAuthor

Thanks for the approval! :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@szaimen@julien-nc@bessw@icewind1991@juliusknorr