Skip to content

Hash cache key - #28481

Merged
juliusknorr merged 1 commit into
masterfrom
fix/hash-key
Aug 18, 2021
Merged

Hash cache key#28481
juliusknorr merged 1 commit into
masterfrom
fix/hash-key

Conversation

@Pytal

@PytalPytal commented Aug 17, 2021

Copy link
Copy Markdown
Member

Hash cache key to ensure that only valid characters are used 🔑

@PytalPytal added bug 3. to review Waiting for reviews labels Aug 17, 2021
@PytalPytal added this to the Nextcloud 23 milestone Aug 17, 2021
@PytalPytal self-assigned this Aug 17, 2021
@Pytal

Pytal commented Aug 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable22

@Pytal

Pytal commented Aug 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable21

@Pytal

Pytal commented Aug 17, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@Pytal
Hash cache key
60ecc43
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv

This comment has been minimized.

Sign in to view
skjnldsv
skjnldsv approved these changes Aug 18, 2021
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 18, 2021
szaimen
szaimen requested changes Aug 18, 2021
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many tests are failing?

@juliusknorr

juliusknorr commented Aug 18, 2021

Copy link
Copy Markdown
Member

Looks like a temporary issue with composer but lets restart

@juliusknorr

juliusknorr commented Aug 18, 2021

Copy link
Copy Markdown
Member

Failure unrelated

@juliusknorr
juliusknorr merged commit 95987d9 into masterAug 18, 2021
@juliusknorr
juliusknorr deleted the fix/hash-key branch August 18, 2021 13:18
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Aug 18, 2021
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Aug 18, 2021
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Aug 18, 2021•
edited by Pytal
Loading

Copy link
Copy Markdown

The backport to stable20 failed. Please do this backport manually.

Not applicable due to cache not being implemented in stable20

@PVince81PVince81 mentioned this pull request Jun 17, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@PVince81PVince81Awaiting requested review from PVince81
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@icewind1991icewind1991Awaiting requested review from icewind1991
@artongeartongeAwaiting requested review from artonge
@szaimenszaimenAwaiting requested review from szaimen

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal@skjnldsv@juliusknorr@blizzz@szaimen