Skip to content

Fix OC.linkToOCS so it works as before @nextcloud/router v2.0.0 - #28506

Merged
szaimen merged 4 commits into
masterfrom
followup/27281/fix-oc-linktoocs
Aug 31, 2021
Merged

Fix OC.linkToOCS so it works as before @nextcloud/router v2.0.0#28506
szaimen merged 4 commits into
masterfrom
followup/27281/fix-oc-linktoocs

Conversation

@nickvergessen

@nickvergessennickvergessen commented Aug 19, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Todo:

@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Aug 19, 2021
@nickvergessennickvergessen added this to the Nextcloud 23 milestone Aug 19, 2021
@nickvergessen

nickvergessen commented Aug 19, 2021

Copy link
Copy Markdown
MemberAuthor

Fixed the occurances

@skjnldsv

skjnldsv commented Aug 19, 2021•
edited
Loading

Copy link
Copy Markdown
Member
 OCA.Files_External.FileList tests
loading file list for external storage
✗ render storage list
Expected 'http://localhost:9876http://localhost/ocs/v2.php/apps/files_external/api/v1/mounts?format=json' to equal 'http://localhost:9876http://localhost/ocs/v1.php/apps/files_external/api/v1/mounts?format=json'.
at Object.<anonymous> (apps/files_external/tests/js/mountsfilelistSpec.js:119:24)

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 19, 2021
@nickvergessennickvergessen added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Aug 20, 2021
@nickvergessen

nickvergessen commented Aug 20, 2021

Copy link
Copy Markdown
MemberAuthor

Fixed

@PVince81

PVince81 commented Aug 24, 2021

Copy link
Copy Markdown
Member

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the followup/27281/fix-oc-linktoocs branch from 12b5656 to d445380CompareAugust 24, 2021 07:05
@szaimen

szaimen commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

Conflicts

@nickvergessen
Fix OC.linkToOCS so it works as before @nextcloud/router v2.0.0
40d4ff3
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Revert OC.linkToOCS() calls back to old behaviour
243098a
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix mountsfilelist to do the v1 call
56c8641
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
d8cbb9f
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the followup/27281/fix-oc-linktoocs branch from d445380 to d8cbb9fCompareAugust 31, 2021 11:02
@nextcloud-command
nextcloud-commandforce-pushed the followup/27281/fix-oc-linktoocs branch from d8cbb9f to ec4ace9CompareAugust 31, 2021 11:04
@nickvergessen
nickvergessenforce-pushed the followup/27281/fix-oc-linktoocs branch from ec4ace9 to d8cbb9fCompareAugust 31, 2021 11:11
@nextcloud-command
nextcloud-commandforce-pushed the followup/27281/fix-oc-linktoocs branch from d8cbb9f to 59ceb95CompareAugust 31, 2021 11:11
@nickvergessen
nickvergessenforce-pushed the followup/27281/fix-oc-linktoocs branch from 59ceb95 to d8cbb9fCompareAugust 31, 2021 11:11
@szaimen
szaimen merged commit ab592c9 into masterAug 31, 2021
@szaimen
szaimen deleted the followup/27281/fix-oc-linktoocs branch August 31, 2021 17:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@skjnldsv@PVince81@szaimen@ChristophWurst